Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

gitserver: Use the same GitBackendSource for all code paths#62613

Merged
eseliger merged 1 commit into
mainfrom
es/05-13-gitserverusethesamegitbackendsourceforallcodepaths
May 13, 2024
Merged

gitserver: Use the same GitBackendSource for all code paths#62613
eseliger merged 1 commit into
mainfrom
es/05-13-gitserverusethesamegitbackendsourceforallcodepaths

Conversation

@eseliger

@eseliger eseliger commented May 13, 2024

Copy link
Copy Markdown
Member

Currently, the janitor doesn't use the observable backend wrapper, this PR makes all users of backend use the same factory function.

Test plan:

Tests are still passing.

@cla-bot cla-bot Bot added the cla-signed label May 13, 2024
This was referenced May 13, 2024
Merged
Merged
Merged
Merged
@eseliger Graphite App

eseliger commented May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @eseliger and the rest of your teammates on Graphite Graphite

@eseliger eseliger mentioned this pull request May 13, 2024
Merged
@github-actions github-actions Bot added team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all labels May 13, 2024
This was referenced May 13, 2024
Merged
Closed
@eseliger eseliger force-pushed the es/05-13-gitserverimplementrefhashinbackend branch from 5f7b386 to d2f4ebf Compare May 13, 2024 03:13
@eseliger eseliger force-pushed the es/05-13-gitserverusethesamegitbackendsourceforallcodepaths branch from 1d73cf2 to fc236cf Compare May 13, 2024 03:13
@eseliger eseliger marked this pull request as ready for review May 13, 2024 03:31
@eseliger eseliger requested a review from a team May 13, 2024 03:31
@eseliger eseliger force-pushed the es/05-13-gitserverimplementrefhashinbackend branch from d2f4ebf to bac718c Compare May 13, 2024 13:15
@eseliger eseliger force-pushed the es/05-13-gitserverusethesamegitbackendsourceforallcodepaths branch from fc236cf to 5dc1957 Compare May 13, 2024 13:15
@eseliger eseliger force-pushed the es/05-13-gitserverimplementrefhashinbackend branch from bac718c to b743fc5 Compare May 13, 2024 13:38
Base automatically changed from es/05-13-gitserverimplementrefhashinbackend to main May 13, 2024 14:05
@eseliger
gitserver: Use the same GitBackendSource for all code paths
866d71e 
Currently, the janitor doesn't use the observable backend wrapper, this PR makes all users of backend use the same factory function.

Test plan:

Tests are still passing.
@eseliger eseliger force-pushed the es/05-13-gitserverusethesamegitbackendsourceforallcodepaths branch from 5dc1957 to 866d71e Compare May 13, 2024 14:07
@eseliger Graphite App

eseliger commented May 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Merge activity

  • May 13, 10:08 AM EDT: Graphite rebased this pull request as part of a merge.
  • May 13, 10:15 AM EDT: @eseliger merged this pull request with Graphite.

@eseliger eseliger merged commit 505e82f into main May 13, 2024
@eseliger eseliger deleted the es/05-13-gitserverusethesamegitbackendsourceforallcodepaths branch May 13, 2024 14:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@pjlast pjlast pjlast approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla-signed team/product-platform team/source Tickets under the purview of Source - the one Source to graph it all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eseliger @pjlast