[GCU E2E Testing] Improve Valid Platform Checker Setup#9878
Merged
isabelmsft merged 7 commits intosonic-net:masterfrom Sep 18, 2023
Merged
[GCU E2E Testing] Improve Valid Platform Checker Setup#9878isabelmsft merged 7 commits intosonic-net:masterfrom
isabelmsft merged 7 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Sep 7, 2023
|
|
||
| CONTAINER_SERVICES_LIST = ["swss", "syncd", "radv", "lldp", "dhcp_relay", "teamd", "bgp", "pmon", "telemetry", "acms"] | ||
| DEFAULT_CHECKPOINT_NAME = "test" | ||
| GCU_SONIC_DIR_PATH = "/usr/local/lib/python3.9/dist-packages/generic_config_updater" |
Contributor
There was a problem hiding this comment.
Hardcoded python3 version is going break in next Debian version. Suggest find the path programmatically.
$ python3
Python 3.9.2 (default, Feb 28 2021, 17:03:44)
[GCC 10.2.1 20210110] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import generic_config_updater
>>> print(generic_config_updater.__path__)
['/usr/local/lib/python3.9/dist-packages/generic_config_updater']
``` #Closed
qiluo-msft
approved these changes
Sep 12, 2023
Collaborator
|
@StormLiangMS Please help cherry-pick this PR to 2023 branch. It's a fix for the GCU test issue. Thanks! |
Contributor
Author
ADO for cherry-pick: 25264431 |
Collaborator
|
Cherry-pick PR to 202305: #10166 |
6 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Sep 28, 2023
isabelmsft
added a commit
that referenced
this pull request
Nov 22, 2023
3 tasks
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 12, 2024
## Description of PR Summary: Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? ADO 17747379 to cherry-pick sonic-utilities PR to 202205 sonic-net/sonic-utilities#3051 requires 202205 sonic-mgmt test update. This PR cherry-picks the following PRs: #7981, #9878 (reads RDMA GCU conf file from DUT instead of copy of conf file in sonic-mgmt), #10214 (fix pfcwd test), #10241 (ensure operation is valid), #10756 (empty string edge case) #### How did you do it? Ensure the feature and tests are stable on 202305 and master #### How did you verify/test it? Monitored test results on 202305 and master for all platforms, manually ran tests on Cisco and Mellanox DUTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Currently, GCU platform validator conf file is copied into sonic-mgmt repository. This PR improves the setup to directly read this file from the DUT instead of having two copies of the file (one in sonic-mgmt and one on the DUT).
Type of change
Back port request
Approach
What is the motivation for this PR?
Improve GCU E2E Testing Setup
How did you do it?
How did you verify/test it?
Ran test on physical DUT
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation