Handle MegaBits speed for show int status <interface> output in test_update_speed testcase#7981
Merged
wangxin merged 2 commits intosonic-net:masterfrom Jun 14, 2023
Merged
Conversation
Collaborator
|
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
Collaborator
|
/azp run |
Blueve
approved these changes
Apr 20, 2023
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@sanjair-git PR conflicts with 202205 branch |
mrkcmo
pushed a commit
to Azarack/sonic-mgmt
that referenced
this pull request
Oct 3, 2023
…update_speed testcase (sonic-net#7981) What is the motivation for this PR? Test case 'test_update_speed' in test_eth_interface.py fails, when the supported selected speed to apply on the interface is in 'Mbps' speed instead of 'Gbps'. How did you do it? If the current status speed after applying the patch is in 'Mbps', handle it as it is done for 'Gbps' speed. How did you verify/test it? Ran the 'test_update_speed' tests against a T2 chassis. Co-authored-by: rawal <amol.rawal@nokia.com>
isabelmsft
pushed a commit
that referenced
this pull request
Nov 22, 2023
…update_speed testcase (#7981) What is the motivation for this PR? Test case 'test_update_speed' in test_eth_interface.py fails, when the supported selected speed to apply on the interface is in 'Mbps' speed instead of 'Gbps'. How did you do it? If the current status speed after applying the patch is in 'Mbps', handle it as it is done for 'Gbps' speed. How did you verify/test it? Ran the 'test_update_speed' tests against a T2 chassis. Co-authored-by: rawal <amol.rawal@nokia.com>
3 tasks
AharonMalkin
pushed a commit
to AharonMalkin/sonic-mgmt
that referenced
this pull request
Jan 25, 2024
…update_speed testcase (sonic-net#7981) What is the motivation for this PR? Test case 'test_update_speed' in test_eth_interface.py fails, when the supported selected speed to apply on the interface is in 'Mbps' speed instead of 'Gbps'. How did you do it? If the current status speed after applying the patch is in 'Mbps', handle it as it is done for 'Gbps' speed. How did you verify/test it? Ran the 'test_update_speed' tests against a T2 chassis. Co-authored-by: rawal <amol.rawal@nokia.com>
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 12, 2024
## Description of PR Summary: Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? ADO 17747379 to cherry-pick sonic-utilities PR to 202205 sonic-net/sonic-utilities#3051 requires 202205 sonic-mgmt test update. This PR cherry-picks the following PRs: #7981, #9878 (reads RDMA GCU conf file from DUT instead of copy of conf file in sonic-mgmt), #10214 (fix pfcwd test), #10241 (ensure operation is valid), #10756 (empty string edge case) #### How did you do it? Ensure the feature and tests are stable on 202305 and master #### How did you verify/test it? Monitored test results on 202305 and master for all platforms, manually ran tests on Cisco and Mellanox DUTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This PR fixes the issue when the supported selected speed to test for the interface is in Mbps instead of Gbps.
Type of change
Back port request
Approach
What is the motivation for this PR?
Test case 'test_update_speed' in test_eth_interface.py fails, when the supported selected speed to apply on the interface is in 'Mbps' speed instead of 'Gbps'.
How did you do it?
If the current status speed after applying the patch is in 'Mbps', handle it as it is done for 'Gbps' speed.
How did you verify/test it?
Ran the 'test_update_speed' tests against a T2 chassis.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation