[GCU] Add check to ensure operation is valid in RDMA validator#10241
[GCU] Add check to ensure operation is valid in RDMA validator#10241isabelmsft merged 18 commits intosonic-net:masterfrom
Conversation
…d_op_check_gcu_rdma
|
The most tricky thing is, GCU will convert |
| tmpfile = generate_tmpfile(duthost) | ||
| output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile) | ||
| if is_valid_platform_and_version(duthost, "PFC_WD", "PFCWD enable/disable"): | ||
| if is_valid_platform_and_version(duthost, "PFC_WD", "PFCWD enable/disable", "add"): |
There was a problem hiding this comment.
This test case only tests 'add', I moved add to be in variable op which would help if we extend the test case
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please check with other active reviewers.
|
LGTM. Also added the label for 202305 branch. |
|
MSFT ADO 25264431 |
|
@isabelmsft PR conflicts with 202305 branch |
|
@isabelmsft cherry pick conflict, could you help to check? |
@StormLiangMS Opened PR #10534 . Cherry-pick conflict was due to #10214 missing from 202305. PR 10534 includes both necessary cherry-picks to 202305 |
## Description of PR Summary: Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? ADO 17747379 to cherry-pick sonic-utilities PR to 202205 sonic-net/sonic-utilities#3051 requires 202205 sonic-mgmt test update. This PR cherry-picks the following PRs: #7981, #9878 (reads RDMA GCU conf file from DUT instead of copy of conf file in sonic-mgmt), #10214 (fix pfcwd test), #10241 (ensure operation is valid), #10756 (empty string edge case) #### How did you do it? Ensure the feature and tests are stable on 202305 and master #### How did you verify/test it? Monitored test results on 202305 and master for all platforms, manually ran tests on Cisco and Mellanox DUTs
Description of PR
Summary:
[GCU] Add check to ensure operation is valid in RDMA validator
ADO 25310959
Type of change
Back port request
Approach
What is the motivation for this PR?
Ensure that operation is allowed in RDMA config update validator
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation