[GCU Testing] Fix is_valid_platform_and_version#10756
Merged
kevinskwang merged 8 commits intosonic-net:masterfrom Nov 16, 2023
Merged
[GCU Testing] Fix is_valid_platform_and_version#10756kevinskwang merged 8 commits intosonic-net:masterfrom
kevinskwang merged 8 commits intosonic-net:masterfrom
Conversation
wen587
approved these changes
Nov 16, 2023
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 20, 2023
* Placeholder return True for valid platform and version * consider empty string as version required
Collaborator
|
Cherry-pick PR to 202305: #10796 |
7 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 20, 2023
* Placeholder return True for valid platform and version * consider empty string as version required
isabelmsft
added a commit
that referenced
this pull request
Nov 22, 2023
* Placeholder return True for valid platform and version * consider empty string as version required
3 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Feb 12, 2024
## Description of PR Summary: Fixes # (issue) ### Type of change - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [x] Test case(new/improvement) ## Approach #### What is the motivation for this PR? ADO 17747379 to cherry-pick sonic-utilities PR to 202205 sonic-net/sonic-utilities#3051 requires 202205 sonic-mgmt test update. This PR cherry-picks the following PRs: #7981, #9878 (reads RDMA GCU conf file from DUT instead of copy of conf file in sonic-mgmt), #10214 (fix pfcwd test), #10241 (ensure operation is valid), #10756 (empty string edge case) #### How did you do it? Ensure the feature and tests are stable on 202305 and master #### How did you verify/test it? Monitored test results on 202305 and master for all platforms, manually ran tests on Cisco and Mellanox DUTs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
ADO 25725929
Ran on previously failing testbed:
generic_config_updater/test_pg_headroom_update.py::test_pg_headroom_update[replace] PASSED [100%]
Type of change
Back port request
Approach
What is the motivation for this PR?
Fix GCU Test Case
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation