Skip to content

Remove duplicated case branches in testbed-cli.sh#854

Merged
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:duplicated-case-branches
Apr 5, 2019
Merged

Remove duplicated case branches in testbed-cli.sh#854
lguohan merged 1 commit intosonic-net:masterfrom
wangxin:duplicated-case-branches

Conversation

@wangxin
Copy link
Copy Markdown
Collaborator

@wangxin wangxin commented Apr 3, 2019

Description of PR

Summary:
Fixes # (issue)
There are some duplicated case branches in the testbed-cli.sh script. Simply removed them.

Type of change

  • Bug fix
  • [] Testbed and Framework(new/improvement)
  • [] Test case(new/improvement)

Approach

How did you do it?

Removed the duplicated case branches in testbed-cli.sh.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

Signed-off-by: Xin Wang <xinw@mellanox.com>
@lguohan lguohan merged commit 3cdd7ec into sonic-net:master Apr 5, 2019
@wangxin wangxin deleted the duplicated-case-branches branch May 24, 2019 03:33
yxieca pushed a commit that referenced this pull request Jul 18, 2019
Signed-off-by: Xin Wang <xinw@mellanox.com>
deerao02 pushed a commit to deerao02/sonic-mgmt that referenced this pull request Dec 18, 2025
sonic-net#854)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit
easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should
reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary: Enhance readability of Jinja logic in select t0 and t1 topology
template files via indentation.

This was originally merged to master in
sonic-net#20490.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [x] Testbed and Framework(new/improvement)
- [ ] New Test case
    - [ ] Skipped for non-supported platforms
- [ ] Test case improvement


### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505

### Approach
#### What is the motivation for this PR?
As a part of other work using the modified t0 and t1 templates, we
needed to add additional Jinja logic in order to support new
capabilities within the testbed peer devices. While doing so we found
that the readability of the existing Jinja logic was vastly improved by
using indentation to reflect the structure of that code.

#### How did you verify/test it?
Ran multiple full suites and saw no regressions related to these
changes.

#### Any platform specific information?
None

#### Supported testbed topology if it's a new test case?
N/A

<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Submodule src/sonic-swss 1bc989a..8ef513c:
  > [teamsyncd]: Add retry logic in teamsyncd to avoid team handler init failure (sonic-net#854)

Submodule src/sonic-utilities e548793..ae274e5:
  > [neighbor advertiser] catch all exceptions while trying https endpoint (sonic-net#757)

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants