[minigraph] always generate neighbor device information#757
Merged
yxieca merged 1 commit intosonic-net:masterfrom Dec 11, 2018
Merged
[minigraph] always generate neighbor device information#757yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
sonic master branch code requires neighbor device presence when parsing minigraph. Without neighbor device information, the minigraph load would fail and leave nightly testbed in bad state if ptf topology was tested in the last step of the test sequence. Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kcudnik
approved these changes
Dec 11, 2018
stcheng
approved these changes
Dec 11, 2018
yxieca
added a commit
that referenced
this pull request
Dec 11, 2018
yxieca
added a commit
that referenced
this pull request
Dec 11, 2018
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
To incldue following changes: - [ci]: add build for arm64 and armhf (sonic-net#757) - Use template hgetall, because we will tune the return types of library functions (sonic-net#759) - [syncd] Fix bulk multi attrs for same key db update (sonic-net#761) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Submodule src/sonic-swss 1bc989a..8ef513c: > [teamsyncd]: Add retry logic in teamsyncd to avoid team handler init failure (sonic-net#854) Submodule src/sonic-utilities e548793..ae274e5: > [neighbor advertiser] catch all exceptions while trying https endpoint (sonic-net#757) Signed-off-by: Ying Xie <ying.xie@microsoft.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
6cfb3ecb0248768da0a91e5f7fb4477c5da7eb4e (HEAD -> 201911, origin/201911) [build]: allow to use extra inc/lib location to build the package (sonic-net#595) 40d34872d3b7f354adac67f084eebf6ee467f779 Merge pull request sonic-net#846 from xumia/azp-201911 76ac50f147a7d820b19d8d7628a67f2fe4f5159b Disable the build test 6c9cf655b8b5b152cab1d578e05eddf8238b81b0 Fix branch reference error ca8d81d37a9b0294098f161b036d330d9ff461e0 [ci]: download artifacts from master branch (sonic-net#768) 0cbf4d55c67a9f8f52715f95536f3588acf06c4a [ci]: use sonicbld pool (sonic-net#766) b6f1265ee9bd86f8a5e909a6f1e9b2384497c906 [ci]: add build for arm64 and armhf (sonic-net#757) 9ec0a7da64d479b124815edc5b505fb88b2532a0 CI: add azure pipeline CI/CD (sonic-net#754) 1436dbe02cd3c56f796c6b3398d4075cd05d97e0 Fix RIF issue (sonic-net#835) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Type of change
Approach
How did you do it?
sonic master branch code requires neighbor device presence when
parsing minigraph. Without neighbor device information, the
minigraph load would fail and leave nightly testbed in bad state
if ptf topology was tested in the last step of the test sequence.
How did you verify/test it?
My nightly testbed has been failure recently with PTF topology due to minigraph issue. With the change. the newly generated minigraph is loaded properly.