Change Jinja logic indentation in t0 and t1 topologies for readability#20490
Merged
bingwang-ms merged 5 commits intosonic-net:masterfrom Oct 23, 2025
Merged
Change Jinja logic indentation in t0 and t1 topologies for readability#20490bingwang-ms merged 5 commits intosonic-net:masterfrom
bingwang-ms merged 5 commits intosonic-net:masterfrom
Conversation
ansible/roles/eos/templates, for readability.
ansible/roles/eos/templates, for readability.
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
approved these changes
Oct 23, 2025
Collaborator
|
no-op change. lgtm. |
Contributor
Author
|
/easycla |
bingwang-ms
approved these changes
Oct 23, 2025
Collaborator
|
hey Will, will need some help taking this change to 202412 @wrideout-arista |
Merged
11 tasks
Contributor
Author
|
@r12f this is ready in Azure/sonic-mgmt.msft#854 |
r12f
pushed a commit
to Azure/sonic-mgmt.msft
that referenced
this pull request
Nov 16, 2025
#854) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. This was originally merged to master in sonic-net/sonic-mgmt#20490. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [x] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? As a part of other work using the modified t0 and t1 templates, we needed to add additional Jinja logic in order to support new capabilities within the testbed peer devices. While doing so we found that the readability of the existing Jinja logic was vastly improved by using indentation to reflect the structure of that code. #### How did you verify/test it? Ran multiple full suites and saw no regressions related to these changes. #### Any platform specific information? None #### Supported testbed topology if it's a new test case? N/A <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
albertovillarreal-keys
pushed a commit
to albertovillarreal-keys/sonic-mgmt
that referenced
this pull request
Dec 2, 2025
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Alberto Villarreal <alberto.villarreal@keysight.com>
opcoder0
pushed a commit
to opcoder0/sonic-mgmt
that referenced
this pull request
Dec 8, 2025
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: opcoder0 <110003254+opcoder0@users.noreply.github.com>
selldinesh
pushed a commit
to selldinesh/sonic-mgmt
that referenced
this pull request
Dec 11, 2025
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: selldinesh <dinesh.sellappan@keysight.com>
saravanan-nexthop
pushed a commit
to saravanan-nexthop/sonic-mgmt
that referenced
this pull request
Dec 15, 2025
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Saravanan <saravanan@nexthop.ai>
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Dec 21, 2025
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
venu-nexthop
pushed a commit
to venu-nexthop/sonic-mgmt
that referenced
this pull request
Jan 13, 2026
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation.
gshemesh2
pushed a commit
to gshemesh2/sonic-mgmt
that referenced
this pull request
Jan 26, 2026
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Guy Shemesh <gshemesh@nvidia.com>
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Jan 29, 2026
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation.
ytzur1
pushed a commit
to ytzur1/sonic-mgmt
that referenced
this pull request
Feb 2, 2026
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Yael Tzur <ytzur@nvidia.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…lly (sonic-net#20490) #### Why I did it src/sonic-swss ``` * 23df60a7 - (HEAD -> 202311, origin/202311) [Orchagent] Add optional create_switch timeout parameter (sonic-net#3322) (19 hours ago) [Rajkumar-Marvell] ``` #### How I did it #### How to verify it #### Description for the changelog
rraghav-cisco
pushed a commit
to rraghav-cisco/sonic-mgmt
that referenced
this pull request
Apr 20, 2026
sonic-net#20490) Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation. Signed-off-by: Raghavendran Ramanathan <rraghav@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Enhance readability of Jinja logic in select t0 and t1 topology template files via indentation.
Type of change
Back port request
Approach
What is the motivation for this PR?
As a part of other work using the modified t0 and t1 templates, we needed to add additional Jinja logic in order to support new capabilities within the testbed peer devices. While doing so we found that the readability of the existing Jinja logic was vastly improved by using indentation to reflect the structure of that code.
How did you verify/test it?
Ran multiple full suites and saw no regressions related to these changes.
Any platform specific information?
None
Supported testbed topology if it's a new test case?
N/A