Skip to content

Revert "[LogAnalyzer]: Accumulate syslog files rather than force logrotate"#641

Merged
sihuihan88 merged 1 commit intomasterfrom
revert-590-dev/sihan/logrotate
Jun 11, 2018
Merged

Revert "[LogAnalyzer]: Accumulate syslog files rather than force logrotate"#641
sihuihan88 merged 1 commit intomasterfrom
revert-590-dev/sihan/logrotate

Conversation

@sihuihan88
Copy link
Copy Markdown
Contributor

Reverts #590

@sihuihan88 sihuihan88 merged commit c225eb5 into master Jun 11, 2018
stepanblyschak pushed a commit to stepanblyschak/sonic-mgmt that referenced this pull request Jul 19, 2018
@stepanblyschak stepanblyschak mentioned this pull request Jul 20, 2018
3 tasks
@qiluo-msft qiluo-msft deleted the revert-590-dev/sihan/logrotate branch July 20, 2018 17:40
maggiemsft pushed a commit that referenced this pull request Jul 24, 2018
* Revert "Revert "[logrotate]: Accumulate syslogs rather than force logrotate (#590)" (#641)"

This reverts commit c225eb5.

* [loganalyze] Make sure logrotate will not run during logs accumulation

Signed-off-by: stepanb <stepanb@mellanox.com>

* Improve "extract_log" ansible module performance

In most scenarios of using this module it is reasonable to search
'start_string' in the most recent log file instead of searching
all appearence of 'start_string' in all logs in /var/log/syslog*.
This improves performance of tests which use loganalyze frequently
(e.g crm, pfc wd)

Signed-off-by: stepanb <stepanb@mellanox.com>
stepanblyschak pushed a commit to stepanblyschak/sonic-mgmt that referenced this pull request Jan 17, 2019
…rotate (sonic-net#590)" (sonic-net#641)"

This reverts commit c225eb5.

Signed-off-by: stepanb <stepanb@mellanox.com>

[logrotate] Make sure logrotate will not interfere with extract logs task for loganalyzer

Signed-off-by: stepanb <stepanb@mellanox.com>
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Oct 27, 2025
…in case packet wasn't correctly sent to the DUT (sonic-net#641)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR
<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

In case of a weak nic, when a packet is not received, resend the packet
Related PR: sonic-net#14139

Summary:
Fixes # (issue)

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?
Avoid failing the test in case of a packet wasn't received because of a weak NIC

#### How did you do it?
Add a retry sending traffic in case a packet wasn't received

#### How did you verify/test it?
Ran test in a loop to ensure its stability

#### Any platform specific information?

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…D automatically (sonic-net#23272)

#### Why I did it
src/sonic-platform-daemons
```
* b4b76a9 - (HEAD -> 202505, origin/202505) [Smartswitch][pcied] Fix pcied handling for smartswitch during DPU detach sonic-net#5 (sonic-net#641) (9 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…c-net#5041)

Update the meta code to support DNAT Pool changes (sonic-net#616)
[syncd] Fix notification on shutdown request (sonic-net#637)
Advance the submodule head of SAI (sonic-net#641)

Signed-off-by: Stephen Sun <stephens@mellanox.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Update the meta code to support DNAT Pool changes (sonic-net#616)
[syncd] Fix notification on shutdown request (sonic-net#637)
Advance the submodule head of SAI (sonic-net#641)
Add new line in sai_meta_log_syncd fprintf call (sonic-net#649)
Fix Warmboot Issue when upgraded Image SAI return Switch Internal
OID not accounted in previous image. (sonic-net#654)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants