Skip to content

Fix test_acl_outer_vlan on dualtor testbed#5041

Merged
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:acl_outer_vlan_dualtor
Jan 29, 2022
Merged

Fix test_acl_outer_vlan on dualtor testbed#5041
bingwang-ms merged 2 commits intosonic-net:masterfrom
bingwang-ms:acl_outer_vlan_dualtor

Conversation

@bingwang-ms
Copy link
Copy Markdown
Collaborator

@bingwang-ms bingwang-ms commented Jan 28, 2022 •
edited
Loading

Signed-off-by: bingwang bingwang@microsoft.com

Description of PR

Summary:
This PR is to fix test_acl_outer_vlan on dualtor testbed.
Currently, the standby tor drops packets from servers by ACL rules matching IN_PORTS. Therefore, if the test was running on standby tor, there will be ACL rules conflicts. The packets will be dropped and result in test failure.

This PR addressed the issue by toggling all mux to the randomly selected tor.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911

Approach

What is the motivation for this PR?

This PR is to fix test_acl_outer_vlan on dualtor testbed.

How did you do it?

This PR addressed the issue by toggling all mux to the randomly selected tor.

How did you verify/test it?

Verified on a dualtor testbed.

collected 16 items                                                                                                                                                                                    

acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_tagged_forwarded[ipv4] PASSED                                                                                                        [  6%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_tagged_dropped[ipv4] PASSED                                                                                                          [ 12%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_untagged_forwarded[ipv4] PASSED                                                                                                      [ 18%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_untagged_dropped[ipv4] PASSED                                                                                                        [ 25%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_tagged_forwarded[ipv4]  ^HPASSED                                                                                               [ 31%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_tagged_dropped[ipv4] PASSED                                                                                                 [ 37%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_untagged_forwarded[ipv4] PASSED                                                                                             [ 43%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_untagged_dropped[ipv4] PASSED                                                                                               [ 50%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_tagged_forwarded[ipv6] PASSED                                                                                                        [ 56%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_tagged_dropped[ipv6] PASSED                                                                                                          [ 62%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_untagged_forwarded[ipv6] PASSED                                                                                                      [ 68%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_untagged_dropped[ipv6]  ^HPASSED                                                                                                        [ 75%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_tagged_forwarded[ipv6] PASSED                                                                                               [ 81%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_tagged_dropped[ipv6] PASSED                                                                                                 [ 87%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_untagged_forwarded[ipv6] PASSED                                                                                             [ 93%]
acl/test_acl_outer_vlan.py::TestAclVlanOuter_Ingress::test_combined_untagged_dropped[ipv6] PASSED                                                                                               [100%

Any platform specific information?

No.

Supported testbed topology if it's a new test case?

No.

Documentation

@bingwang-ms
Fix test_acl_outer_vlan on dualtor testbed
9e109ca 
Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms
Ignore LGTM
5c14ea7 
Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms bingwang-ms requested a review from a team as a code owner January 28, 2022 09:01
@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 28, 2022

This pull request introduces 1 alert when merging 9e109ca into 5671856 - view on LGTM.com

new alerts:

  • 1 for Unused import

@lgtm-com
Copy link
Copy Markdown

lgtm-com bot commented Jan 28, 2022

This pull request introduces 1 alert when merging 5c14ea7 into 5671856 - view on LGTM.com

new alerts:

  • 1 for Unused import

@bingwang-ms bingwang-ms merged commit ac8862d into sonic-net:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lolyu lolyu lolyu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bingwang-ms @lolyu