Add option for sanity check skip#616
Closed
andriymoroz-mlnx wants to merge 2 commits intosonic-net:masterfrom
Closed
Add option for sanity check skip#616andriymoroz-mlnx wants to merge 2 commits intosonic-net:masterfrom
andriymoroz-mlnx wants to merge 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
Can be used to run sanity check only Signed-off-by: Andriy Moroz <c_andriym@mellanox.com>
auspham
pushed a commit
to auspham/sonic-mgmt
that referenced
this pull request
Feb 3, 2026
…ap] Use conditional sleep based on route scale (sonic-net#616) <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR Replaced the fixed 180-second sleep in `test_nhop_group_interface_flap` with a conditional wait based on the number of eBGP v4/v6 routes on the DUT. - Retrieves eBGP v4 and v6 route counts via `get_ip_route_summary()`. - Sleeps for: - **180 seconds** if v4 or v6 eBGP route count exceeds 10,000. - **20 seconds** otherwise. Summary: Fixes # (issue) The current implementation applies a fixed time.sleep(180) only for chassis systems. However, during nightly runs on disagg-T2 devices, we observed that they also require an increased timeout for route programming, similar to chassis platforms. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 ### Approach #### What is the motivation for this PR? Enhance the time.sleep logic to support additional platforms beyond chassis systems. #### How did you do it? Retrieve eBGP v4 and v6 route counts using get_ip_route_summary(). If either count exceeds 10,000, apply a 180-second sleep; otherwise, use a shorter delay. #### How did you verify/test it? Validated the change by running the test in the Microsoft lab. #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
…c-net#5041) Update the meta code to support DNAT Pool changes (sonic-net#616) [syncd] Fix notification on shutdown request (sonic-net#637) Advance the submodule head of SAI (sonic-net#641) Signed-off-by: Stephen Sun <stephens@mellanox.com>
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
Update the meta code to support DNAT Pool changes (sonic-net#616) [syncd] Fix notification on shutdown request (sonic-net#637) Advance the submodule head of SAI (sonic-net#641) Add new line in sai_meta_log_syncd fprintf call (sonic-net#649) Fix Warmboot Issue when upgraded Image SAI return Switch Internal OID not accounted in previous image. (sonic-net#654)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz c_andriym@mellanox.com
Description of PR
Added option "skip_sanity", which can be specified on test start:
e.g.
ansible-playbook test_sonic.yml... -e skip_sanity=trueand will skip switch sanity check before and after the test
Does not change the default behavior (i.e. if not specified - sanity will run)
UPD: Added dummy test which can be run to perform sanity check only
Type of change
Approach
How did you do it?
Updated sanity check run to execute only when variable skip_sanity is undefined or not equal "true"
How did you verify/test it?
ran with -e skip_sanity=true and made sure sanity did not run