Skip to content

Ansible - Bugfixes for example playbook#5

Merged
johnarnold merged 7 commits intosonic-net:masterfrom
johnarnold:sonic-common4
Sep 13, 2016
Merged

Ansible - Bugfixes for example playbook#5
johnarnold merged 7 commits intosonic-net:masterfrom
johnarnold:sonic-common4

Conversation

@johnarnold
Copy link
Copy Markdown
Contributor

Changes:

Ansible: Added missing files and synced latest changes from internal
Add opennsl to package_versions
Added apt_default_release to vars
Updated quagga.yml -- static set docker_image for v1 remove
Updated minigraph_facts.yml -- loopback interfaces into list

Signed-Off-By: John Arnold johnar@microsoft.com

@johnarnold johnarnold merged commit 5a0289f into sonic-net:master Sep 13, 2016
wangxin pushed a commit that referenced this pull request Aug 3, 2023
What is the motivation for this PR?
The primary motivation for these modifications was to set up a virtual machine (VM) topology and ensure that the 'test_bgp_scalability.py' runs smoothly on both VM and hardware setups.

How did you do it?
These improvements and fixes were achieved by adjusting the indexing in the 'bgp_test_gap_helper.py' file, adding logic to disable the 'EnableDataPlaneEventsRateMonitor' for VM setups, and fixing attribute errors.

How did you verify/test it?
The 'test_bgp_scalability.py' was run on both hardware and VM setups. Both setups passed the test as expected.

Any platform specific information?
IxNetwork Application Version: 9.30.2212.22 on a virtual machine, used for both VM and HW setups.
IxChassis Application Version: 9.21 on a virtual machine and for the hardware setup.
Application Version: 9.30 on two Load Module virtual machines attached to a virtual IxChassis.
DUT SONiC-OS-202205.302215-e8e8c019c for VM setup.
DUT SONiC-OS-202205.262571-f2a687b33 for the hardware setup.

Documentation
Instructions on setting up a VM topology for testing have been added.
docs/testbed/README.testbed.Keysight.md
docs/testbed/README.testbed.Setup.md
AharonMalkin pushed a commit to AharonMalkin/sonic-mgmt that referenced this pull request Jan 25, 2024
What is the motivation for this PR?
The primary motivation for these modifications was to set up a virtual machine (VM) topology and ensure that the 'test_bgp_scalability.py' runs smoothly on both VM and hardware setups.

How did you do it?
These improvements and fixes were achieved by adjusting the indexing in the 'bgp_test_gap_helper.py' file, adding logic to disable the 'EnableDataPlaneEventsRateMonitor' for VM setups, and fixing attribute errors.

How did you verify/test it?
The 'test_bgp_scalability.py' was run on both hardware and VM setups. Both setups passed the test as expected.

Any platform specific information?
IxNetwork Application Version: 9.30.2212.22 on a virtual machine, used for both VM and HW setups.
IxChassis Application Version: 9.21 on a virtual machine and for the hardware setup.
Application Version: 9.30 on two Load Module virtual machines attached to a virtual IxChassis.
DUT SONiC-OS-202205.302215-e8e8c019c for VM setup.
DUT SONiC-OS-202205.262571-f2a687b33 for the hardware setup.

Documentation
Instructions on setting up a VM topology for testing have been added.
docs/testbed/README.testbed.Keysight.md
docs/testbed/README.testbed.Setup.md
yejianquan added a commit to yejianquan/sonic-mgmt that referenced this pull request Jan 17, 2025
sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708)

Approach
What is the motivation for this PR?
We are seeing UnboundLocalError when running sonic-mgmt tests against a single-ASIC linecard:

UnboundLocalError: local variable 'dst_sys_port_id' referenced before assignment
Upon further investigation, this was determined to be happening because a previous attempt to fix this issue (PR sonic-net#13700) completely omitted the ASIC prefix, but the entries in SYSTEM_PORT in config_db do have an Asic0 prefix even on a single ASIC DUT.

How did you do it?
Resolve this by specifically adding the Asic0 prefix in the case of a single-ASIC T2 DUT, instead of leaving the prefix out.

How did you verify/test it?
Tested by manually running qos tests on a T2 single ASIC DUT with these changes.

co-authorized by: jianquanye@microsoft.com
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
6c6151b Fix unstable unit tests (state change handler wasn't invoked) (sonic-net#8)
2f7dc0a support code diff coverage (sonic-net#5)
83f0002 Force mux state switch to standby if triggered from Cli (sonic-net#6)

signed-off-by: Jing Zhang zhangjing@microsoft.com
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Why I did it
Advance sonic-dhcp-relay submodule head on 202012 branch

How I did it
Added the following commits:
a4b15d8 jcaiMR Thu Dec 29 14:18:28 2022 +0800 fix relay-reply dhcpv6 packet counter issue (sonic-net#29)
677543f jcaiMR Sat Dec 17 00:24:32 2022 +0800 fix handleSwssNotification crash in dhcp6relay (sonic-net#28)
ed86546 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (sonic-net#27)
5ec1f5b Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (sonic-net#22)
063d41b jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (sonic-net#25)
d4a51f6 kellyyeh Tue Jan 31 18:09:08 2023 -0800 Add unittest infrastructure (sonic-net#5) (sonic-net#31)

How to verify it
Ran full dhcpv6 test suite on lab device
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…D automatically (sonic-net#23272)

#### Why I did it
src/sonic-platform-daemons
```
* b4b76a9 - (HEAD -> 202505, origin/202505) [Smartswitch][pcied] Fix pcied handling for smartswitch during DPU detach sonic-net#5 (sonic-net#641) (9 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…et#21405)

<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

```
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#1 0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#2 0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#3 0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
sonic-net#4 0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
sonic-net#5 0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
sonic-net#6 route_next (node=<optimized out>) at ../lib/table.c:436
sonic-net#7 route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
sonic-net#8 0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
 at ../zebra/interface.c:312
sonic-net#9 0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
sonic-net#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
sonic-net#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
sonic-net#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
sonic-net#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
sonic-net#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
```

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added patch.

#### How to verify it
Running BGP tests.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026


advance dhcp relay for 202211

4bf1868 - (HEAD, origin/master, origin/HEAD, master) fix relay-reply dhcpv6 packet counter issue (add support for a7050 qx32 platform sonic-net#29) (2 weeks ago) [jcaiMR]
9b30690 - fix handleSwssNotification crash in dhcp6relay (Add libnl-nf-3-200 to docker-team sonic-net#28) (4 weeks ago) [jcaiMR]
047afb7 - Fix multiple vlan issue (Failure trying to run: chroot /sonic-buildimage/fsroot mount -t proc proc /proc sonic-net#27) (4 weeks ago) [jcaiMR]
ff6bec3 - Made the Error log informative (add python-tenjin as build dependency for p4-switch sonic-net#22) (5 weeks ago) [Vivek]
2fbe729 - disable cfg dynamic change (p4: fix build dependency for python-p4c-bm sonic-net#25) (6 weeks ago) [jcaiMR]
13d0805 - Use github code scanning instead of LGTM (Removed sx-libnl from Mellanox containers dependencies. sonic-net#26) (6 weeks ago) [Liu Shilong]
1e846f6 - Fix packet range check for relay-reply packets (update sonic-swss and p4-switch submodule to fix docker sonic p4 bug sonic-net#21) (7 weeks ago) [kellyyeh]
4d19e13 - Add unittest infrastructure (Cavium customization for docker containers sonic-net#5) (8 weeks ago) [kellyyeh]
7f4fdab - fix packet range check issue (Makefile: add build dependency for python-p4c-bm sonic-net#20) (9 weeks ago) [jcaiMR]
257ecdf - Add client packet UDP header length check (change port_config.ini directory for s6000 sonic-net#19) (2 months ago) [kellyyeh]
wangxin added a commit to wangxin/sonic-mgmt that referenced this pull request Mar 9, 2026
Fix three issues raised in code review:

Issue sonic-net#2 - ceos_effective_image undefined in ceos_ensure_reachable.yml:
Add a defensive set_fact at the top of ceos_ensure_reachable.yml that
sets ceos_effective_image to ceos_image as a fallback, guarded by
'when: ceos_effective_image is not defined'. In the normal flow the
variable is already set by the caller (ceos.yml in the eos role) so
this task is a no-op. It prevents an undefined variable error if the
file is ever invoked independently.

Issue sonic-net#3 - ceos_image_found stored as string instead of boolean:
The set_fact used a >- block scalar which causes Jinja2 to produce the
string 'True'/'False'. In Ansible the string 'False' is truthy, so
'when: not ceos_image_found' would never enter the prepare block when
the image is absent. Fixed by collapsing to a single quoted expression
and appending '| bool' to ensure Python boolean storage.

Issue sonic-net#5 - registry pull failure silently ignored:
Added a debug task immediately after the pull task that emits a WARNING
message when ceos_registry_pull_result is failed. Users can now see in
the Ansible output why the fallback to download-and-build was triggered.

Signed-off-by: Xin Wang <xiwang5@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant