Skip to content

Quagga templates inheritance#21

Closed
NStetskovych-zz wants to merge 2 commits intosonic-net:masterfrom
NStetskovych-zz:quagga_templ_inheritance
Closed

Quagga templates inheritance#21
NStetskovych-zz wants to merge 2 commits intosonic-net:masterfrom
NStetskovych-zz:quagga_templ_inheritance

Conversation

@NStetskovych-zz
Copy link
Copy Markdown

Propose changes to configure zebra for different platforms in different ways

Nadiya.Stetskovych added 2 commits October 11, 2016 15:54
Signed-off-by: Nadiya.Stetskovych <Nadiya.Stetskovych@cavium.com>
Signed-off-by: Nadiya.Stetskovych <Nadiya.Stetskovych@cavium.com>
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 11, 2016

can you help to explain why quagga configuration is asic platform dependent?

@NStetskovych-zz
Copy link
Copy Markdown
Author

Actually it is not :). For now default config file for zеbra configuration contain parts that is not mandatory. Just want to propose the way every vendor can easy customize configuration (not breaking default config) using current sonic-mgmt deployment.

@qiluo-msft
Copy link
Copy Markdown
Contributor

Could you give more details about "default config file for zеbra configuration contain parts that is not mandatory"?

@NStetskovych-zz
Copy link
Copy Markdown
Author

NStetskovych-zz commented Oct 12, 2016

By current default zebra config all src ports will have loopback ip. But lets consider the attached config that not require 'set src' configuration. By current implementation its look impossible just remove minigraph_lo_interfaces from minigraph_fact.yaml (and generate other template by adding validation whether we have lo interface )
DUT1.txt

Thanks.

@NStetskovych-zz
Copy link
Copy Markdown
Author

Could we just remove set src config from default?

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Oct 19, 2016

no, it is required by sonic configuration. why do you want to remove minigraph_lo_interfaces? there is no harm to have it, right?

@NStetskovych-zz
Copy link
Copy Markdown
Author

I mean take away from zebra default config. Do you consider attached above config valid (in the text file)? Now it is impossible to generate such config because all src port will point to loopback ip.

@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Dec 29, 2016

there is no plan to introduction hw platform specific quagga configuration, any concern to close this PR?

wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025
Fix fabric_cli_and_db so it only tests on connected links. (sonic-net#16309)
devin-ai-integration bot pushed a commit to bpar9/sonic-mgmt that referenced this pull request Jan 17, 2026
…al-Preference testplan

- Test Case sonic-net#17: Local-Preference Preservation via Route Reflector
- Test Case sonic-net#18: Local-Preference Set by Route Reflector
- Test Case sonic-net#19: Local-Preference Best Path Selection via Route Reflector
- Test Case sonic-net#20: Local-Preference with Multiple Route Reflector Clients
- Test Case sonic-net#21: Local-Preference Override at Route Reflector Client
- Updated scope section to include route reflector scenarios
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
cde2966 2018-06-26 | * Reduce severity of log 'vty connect from' from INFO to DEBUG (sonic-net#21) (HEAD) [pavel-shirshov]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026


advance dhcp relay for 202211

4bf1868 - (HEAD, origin/master, origin/HEAD, master) fix relay-reply dhcpv6 packet counter issue (add support for a7050 qx32 platform sonic-net#29) (2 weeks ago) [jcaiMR]
9b30690 - fix handleSwssNotification crash in dhcp6relay (Add libnl-nf-3-200 to docker-team sonic-net#28) (4 weeks ago) [jcaiMR]
047afb7 - Fix multiple vlan issue (Failure trying to run: chroot /sonic-buildimage/fsroot mount -t proc proc /proc sonic-net#27) (4 weeks ago) [jcaiMR]
ff6bec3 - Made the Error log informative (add python-tenjin as build dependency for p4-switch sonic-net#22) (5 weeks ago) [Vivek]
2fbe729 - disable cfg dynamic change (p4: fix build dependency for python-p4c-bm sonic-net#25) (6 weeks ago) [jcaiMR]
13d0805 - Use github code scanning instead of LGTM (Removed sx-libnl from Mellanox containers dependencies. sonic-net#26) (6 weeks ago) [Liu Shilong]
1e846f6 - Fix packet range check for relay-reply packets (update sonic-swss and p4-switch submodule to fix docker sonic p4 bug sonic-net#21) (7 weeks ago) [kellyyeh]
4d19e13 - Add unittest infrastructure (Cavium customization for docker containers sonic-net#5) (8 weeks ago) [kellyyeh]
7f4fdab - fix packet range check issue (Makefile: add build dependency for python-p4c-bm sonic-net#20) (9 weeks ago) [jcaiMR]
257ecdf - Add client packet UDP header length check (change port_config.ini directory for s6000 sonic-net#19) (2 months ago) [kellyyeh]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants