Skip to content

[PFCWD]: Add support for t0 toplogy and arista fanout testbed#424

Merged
sihuihan88 merged 1 commit intosonic-net:masterfrom
sihuihan88:dev/sihan/pfc
Jan 25, 2018
Merged

[PFCWD]: Add support for t0 toplogy and arista fanout testbed#424
sihuihan88 merged 1 commit intosonic-net:masterfrom
sihuihan88:dev/sihan/pfc

Conversation

@sihuihan88
Copy link
Copy Markdown
Contributor

@sihuihan88 sihuihan88 commented Jan 13, 2018 •
edited
Loading

Signed-off-by: Sihui Han sihan@microsoft.com

Description of PR

Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Approach

How did you do it?
Add support for t0 toplogy and arista fanout testbed
How did you verify/test it?
Tested on DUT
Any platform specific information?
Supported testbed topology if it's a new test case?

Documentation

@sihuihan88 sihuihan88 self-assigned this Jan 13, 2018
@lguohan
Copy link
Copy Markdown
Contributor

lguohan commented Jan 13, 2018

@marian-pritsak , can you review?

marian-pritsak
marian-pritsak reviewed Jan 19, 2018
View reviewed changes
ansible/roles/test/files/helpers/pfctest.py Outdated
Copy link
Copy Markdown
Contributor

@marian-pritsak marian-pritsak Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script was taken from another repo. Can you please check if licenses are compatible?

Copy link
Copy Markdown
Contributor Author

@sihuihan88 sihuihan88 Jan 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, good point. I will make sure licenses before checking in.

marian-pritsak
marian-pritsak reviewed Jan 19, 2018
View reviewed changes
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test.yml Outdated
Copy link
Copy Markdown
Contributor

@marian-pritsak marian-pritsak Jan 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why touch?

Copy link
Copy Markdown
Contributor Author

@sihuihan88 sihuihan88 Jan 20, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy the script will fail if the file doesn't exist on this platform. So create the file first.

yxieca
yxieca reviewed Jan 25, 2018
View reviewed changes
ansible/roles/test/files/helpers/pfc_gen.py Outdated
Copy link
Copy Markdown
Collaborator

@yxieca yxieca Jan 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here? s/655535/65535 ?

yxieca
yxieca reviewed Jan 25, 2018
View reviewed changes
ansible/roles/test/tasks/pfc_wd/functional_test/functional_test.yml Outdated
Copy link
Copy Markdown
Collaborator

@yxieca yxieca Jan 25, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

start=1 end={{total_run}} can be simplified to count={{total_run}}, unless you want to run total_run - 1 iterations?

OK I figured it out. By default start=1, so start=1 end={{total_num}} is good, so is count={{total_num}}

You don't have to change.

[PFCWD]: Add Add support for t0 toplogy and arista fanout testbed
0181a01 
Signed-off-by: Sihui Han <sihan@microsoft.com>
@sihuihan88 sihuihan88 merged commit 42241a2 into sonic-net:master Jan 25, 2018
praveen-li pushed a commit to praveen-li/sonic-mgmt that referenced this pull request Jun 20, 2019
@zhenggen-xu
Merge remote-tracking branch 'msft_github/master'
f2a4b70 
* msft_github/master:
  [PFCWD]: Add Add support for t0 toplogy and arista fanout testbed (sonic-net#424)
  add orchagent process check before each test and sanity after each test (sonic-net#431)
  Move mem_check.sh into helpers/ directory to conform with location of other helper scripts (sonic-net#435)
  fix tests for t0-116 topology (sonic-net#430)
  Updated labinfo file with Arista fanout sku (sonic-net#429)
  add missing snmp testcases to top level snmp.yml; fixed wrong test file for neighbour test; change arp test comment more readable (sonic-net#428)
  Fix sku-sensors-data for 7060 (sonic-net#427)
  Fix port alias mapping for Arista-7050QX-32S (sonic-net#426)
  [Lag 2] Allow lacp timing tests to retry limited times until succeeded (sonic-net#403)
  [hwsku]: Add Accton-AS7716-32X (sonic-net#405)
  add generate minigrah using testbed_name option (sonic-net#425)
  Update README.testbed.md
  Create README.testbed.Example.md
  Update README.testbed.Config.md
  add missing test case name (sonic-net#417)
  fix typo when assign dscp_mode for decap test (sonic-net#418)
  [repeat harness] rework repeat harness and introduce test case continuous reboot (sonic-net#416)
  allow upgrade sonic via onie or sonic-to-sonic upgrade method (sonic-net#413)
  [topology]: Fix t1-64-lag topology device link base indices (sonic-net#414)
  Run sudo command with log_analyzer (sonic-net#415)
  [sonic tests] use host time instead of ansible time (sonic-net#410)
  [upgrade_sonic]: Fix the hostname in the wait_for condition (sonic-net#411)
  [Test cases] clean up some test cases changes and enabling more tests (sonic-net#409)
  add restart_swss (sonic-net#412)
  [sonic test] introduce a repeat harness (sonic-net#402)
  Update README.test.md
  [bgp_speaker]: always clean up test environment after it finishes (sonic-net#406)
  [vlan]: add vlan test to test by testname (sonic-net#408)
  [bug]: convert the interface from unicode to string (sonic-net#407)
  [VLAN test] Add VLAN test (sonic-net#375)
  [vm]: change the default Front plane port to 4 instead of 8 (sonic-net#404)
  Update README.testbed.Setup.md
  [acl]: Adopt tests with acl-loader to t0 and t1-lag topo. (sonic-net#370)
  add connect_topo command for testbed-cli.sh (sonic-net#398)
  [FIB, BGP speaker] fix t0-116 topology source port list (sonic-net#396)
  [bgp_speaker]: Specify VLAN IP route in case LPM to other nexthop (sonic-net#394)
  [sensor]: Change sensor labels for Arista 7050 and 7260 (sonic-net#395)
  Delete Arista DPMs sensors data (sonic-net#393)
  [bug]: change maximum packet to 9114 to send in the mtu test (sonic-net#391)
sdszhang pushed a commit to sdszhang/sonic-mgmt that referenced this pull request Jun 30, 2025
@az-pz
[202412] Fix txvr tests after diagnostic table restructuring (sonic-n…
880a77a 
…et#424)
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
@lguohan
[submodule]: update sonic-swss and sonic-sairedis submodule
8f077b8 
sonic-swss

* 32d3297 2019-01-24 | use sai_stat_id_t for new SAI header file (sonic-net#769)

sonic-sairedis

* fdfcefd 2019-04-24 | [SAI] Advance submodule to v1.4.1 (sonic-net#450) (HEAD -> 201811, origin/201811) [Marian Pritsak]
* 006df41 2019-02-27 | [vslib]: Add support of bitmap VNET (bmtor) SAI API (sonic-net#424) [Volodymyr Samotiy]
* ec5e187 2019-04-23 | [SAI]: Move SAI pointer to v1.4 (sonic-net#447) [Shuotian Cheng]
* 6b9c32e 2019-03-04 | [SAI] Update SAI pointer (sonic-net#431) [Stepan Blyshchak]
* f078998 2019-02-22 | Fix compilation issues in stretch docker with gcc-6.3 (sonic-net#426) [Stepan Blyshchak]
* 0540e59 2019-01-31 | Update SAI pointer (sonic-net#414) [Marian Pritsak]
* 9084920 2019-01-18 | Update SAI pointer to latest master (sonic-net#408) [Marian Pritsak]
* fbfe48b 2019-06-24 | Revert "[SAI header] upgrade SAI header to version v1.3.7 (sonic-net#445)" [Guohan Lu]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marian-pritsak marian-pritsak marian-pritsak left review comments

@yxieca yxieca yxieca approved these changes

Assignees

@sihuihan88 sihuihan88

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sihuihan88 @lguohan @marian-pritsak @yxieca