Skip to content

[warm/fast reboot] refactoring advanced-reboot script#769

Merged
yxieca merged 18 commits intosonic-net:masterfrom
yxieca:warmboot
Jan 10, 2019
Merged

[warm/fast reboot] refactoring advanced-reboot script#769
yxieca merged 18 commits intosonic-net:masterfrom
yxieca:warmboot

Conversation

@yxieca
Copy link
Copy Markdown
Collaborator

@yxieca yxieca commented Jan 9, 2019

  • Bug fix
  • Testbed and Framework(new/improvement)

Approach

How did you do it?

At high level, this change addresses a few issues I encountered when running fast-reboot test. As it stands now, the script hasn't been fully adapted to support warm-reboot yet.

Issues addressed:

  • When having more than one thread sending data plane/control plane probes, they will all fail due to not getting all responses back.
  • Some minor issues that shows up randomly.

Approach taking:

  • Introduced a watcher thread to send probes and analyze results. Then update states accordingly.
  • Other parties who requires information can start thread to wait for certain state change. But don't send probe IO themselves.

How did you verify/test it?

  • passed fast-reboot test multiple times on one platform.

yxieca added 10 commits January 9, 2019 17:35
The arp_responder might be enabled by another test with different
configuration but left running. To guarantee the latest configuration
is used, always restart arp_responder.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Create the pool earlier so other code could share it.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
When some part of the test doesn't work properly, these variables got
picked up to generated exception because they were not initialized.

Initializing them just so that the failure won't be that they are not
initialized. The script still fails and hopefully that would be less
confusing.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…ructure

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Copy link
Copy Markdown
Contributor

@pavel-shirshov pavel-shirshov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As comments

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
We have up to 3 concurrent tasks so far. Reduce the pool size to 5 to
reduce resource footprint and leave some space for more parallel tasks
in the future.

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
CPU  -> control plane
ASIC -> data plane
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
…rency

Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
@yxieca yxieca merged commit c1a3429 into sonic-net:master Jan 10, 2019
@yxieca yxieca deleted the warmboot branch January 10, 2019 22:47
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
[ci]: download artifacts from master branch (sonic-net#768)
Do not create fabric port if mapping is not available (sonic-net#769)
[syncd] Comparison logic log also current attr value on set operation (sonic-net#763)
Add fabric port test to vslib (sonic-net#737)
[ci]: use sonicbld pool (sonic-net#766)
[tests] Remove exit command blocking all tests to run (sonic-net#765)
[vslib]: adapt macsec sai 1.7.1 (sonic-net#755)
Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (sonic-net#756)

Signed-off-by: Danny Allen <daall@microsoft.com>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-swss

* 32d3297 2019-01-24 | use sai_stat_id_t for new SAI header file (sonic-net#769)

sonic-sairedis

* fdfcefd 2019-04-24 | [SAI] Advance submodule to v1.4.1 (sonic-net#450) (HEAD -> 201811, origin/201811) [Marian Pritsak]
* 006df41 2019-02-27 | [vslib]: Add support of bitmap VNET (bmtor) SAI API (sonic-net#424) [Volodymyr Samotiy]
* ec5e187 2019-04-23 | [SAI]: Move SAI pointer to v1.4 (sonic-net#447) [Shuotian Cheng]
* 6b9c32e 2019-03-04 | [SAI] Update SAI pointer (sonic-net#431) [Stepan Blyshchak]
* f078998 2019-02-22 | Fix compilation issues in stretch docker with gcc-6.3 (sonic-net#426) [Stepan Blyshchak]
* 0540e59 2019-01-31 | Update SAI pointer (sonic-net#414) [Marian Pritsak]
* 9084920 2019-01-18 | Update SAI pointer to latest master (sonic-net#408) [Marian Pritsak]
* fbfe48b 2019-06-24 | Revert "[SAI header] upgrade SAI header to version v1.3.7 (sonic-net#445)" [Guohan Lu]

Signed-off-by: Guohan Lu <gulv@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants