Replace shutdown with reboot#765
Merged
lguohan merged 2 commits intosonic-net:masterfrom Jan 23, 2019
wangxin:replace-shutdown
Merged
Replace shutdown with reboot#765lguohan merged 2 commits intosonic-net:masterfrom wangxin:replace-shutdown
lguohan merged 2 commits intosonic-net:masterfrom
wangxin:replace-shutdown
Conversation
The reboot command can do some additional work like firmware update. Replaced the shutdown command with reboot. Increased the delay time for checking switch connectivity after reboot to 3 minutes because of potential firmware update. Signed-off-by: Xin Wang <xinw@mellanox.com>
nikos-github
approved these changes
Dec 27, 2018
Reboot may need some time to update firmware firstly. Increasing the async time to 300 seconds to avoid reboot being interrupted. Signed-off-by: Xin Wang <xinw@mellanox.com>
jleveque
approved these changes
Jan 2, 2019
lguohan
approved these changes
Jan 23, 2019
Collaborator
|
Made to 201811 branch on 1/25/2019 |
wangxin
pushed a commit
to wangxin/sonic-mgmt
that referenced
this pull request
Oct 27, 2025
…ed-d56u1-lag. And re-… (sonic-net#765) …order tests <!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [x] 202411 - [x] 202505 ### Approach #### What is the motivation for this PR? To skip test_vxlan_ecmp_vnet_ping test for t1-isolated-d56u1-lag, which is not needed in AI back end #### How did you do it? Added in tests/common/plugins/conditional_mark/tests_mark_conditions.yaml #### How did you verify/test it? #### Any platform specific information? #### Supported testbed topology if it's a new test case? ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
kazinator-arista
pushed a commit
to kazinator-arista/sonic-mgmt
that referenced
this pull request
Mar 4, 2026
[ci]: download artifacts from master branch (sonic-net#768) Do not create fabric port if mapping is not available (sonic-net#769) [syncd] Comparison logic log also current attr value on set operation (sonic-net#763) Add fabric port test to vslib (sonic-net#737) [ci]: use sonicbld pool (sonic-net#766) [tests] Remove exit command blocking all tests to run (sonic-net#765) [vslib]: adapt macsec sai 1.7.1 (sonic-net#755) Add support for SAI_SWITCH_ATTR_AVAILABLE_IPMC_ENTRY needed by CRM (sonic-net#756) Signed-off-by: Danny Allen <daall@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reboot command can do some additional work like firmware update.
Replaced the shutdown command with reboot. Increased the delay time
for checking switch connectivity after reboot to 3 minutes because of
potential firmware update.
Signed-off-by: Xin Wang xinw@mellanox.com
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
How did you do it?
Replaced the "shutdown -r now" command with "reboot". Increased the delay time for checking switch connectivity.
How did you verify/test it?
Tested on Mellanox platform.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation