[Lag 2] Allow lacp timing tests to retry limited times until succeeded#403
Merged
lguohan merged 4 commits intosonic-net:masterfrom Jan 13, 2018
Merged
[Lag 2] Allow lacp timing tests to retry limited times until succeeded#403lguohan merged 4 commits intosonic-net:masterfrom
lguohan merged 4 commits intosonic-net:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Approach
How did you do it?
lag_2 test has a pretty high failure rate. Most failures are at the lacp frame timing test. This test is testing if DUT would receive LACP frames at the internal consistent with the rate setting, fast: 1 sec, normal: 30 seconds. Test failures are almost always failed to receive 2 packets at the specified interval.
There are too many reasons that could happen. I propose that as long as we receive a pair of frames fits the expected interval within reasonable number of retries (10), the test should pass.
How did you verify/test it?
Repeated execute the lag_2 test, normally the test would fail with 10 retries. With the change, test executed for 70+ times.