[sonic tests] use host time instead of ansible time#410
Merged
lguohan merged 1 commit intosonic-net:masterfrom Jan 4, 2018
Merged
[sonic tests] use host time instead of ansible time#410lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Ansible time could be cached, causing multiple consecutive tests using a same time stamp to create log files and losing older log files. Changing to local host time would make time stamp always unique.
lguohan
approved these changes
Jan 4, 2018
praveen-li
pushed a commit
to praveen-li/sonic-mgmt
that referenced
this pull request
Jun 20, 2019
* msft_github/master: [PFCWD]: Add Add support for t0 toplogy and arista fanout testbed (sonic-net#424) add orchagent process check before each test and sanity after each test (sonic-net#431) Move mem_check.sh into helpers/ directory to conform with location of other helper scripts (sonic-net#435) fix tests for t0-116 topology (sonic-net#430) Updated labinfo file with Arista fanout sku (sonic-net#429) add missing snmp testcases to top level snmp.yml; fixed wrong test file for neighbour test; change arp test comment more readable (sonic-net#428) Fix sku-sensors-data for 7060 (sonic-net#427) Fix port alias mapping for Arista-7050QX-32S (sonic-net#426) [Lag 2] Allow lacp timing tests to retry limited times until succeeded (sonic-net#403) [hwsku]: Add Accton-AS7716-32X (sonic-net#405) add generate minigrah using testbed_name option (sonic-net#425) Update README.testbed.md Create README.testbed.Example.md Update README.testbed.Config.md add missing test case name (sonic-net#417) fix typo when assign dscp_mode for decap test (sonic-net#418) [repeat harness] rework repeat harness and introduce test case continuous reboot (sonic-net#416) allow upgrade sonic via onie or sonic-to-sonic upgrade method (sonic-net#413) [topology]: Fix t1-64-lag topology device link base indices (sonic-net#414) Run sudo command with log_analyzer (sonic-net#415) [sonic tests] use host time instead of ansible time (sonic-net#410) [upgrade_sonic]: Fix the hostname in the wait_for condition (sonic-net#411) [Test cases] clean up some test cases changes and enabling more tests (sonic-net#409) add restart_swss (sonic-net#412) [sonic test] introduce a repeat harness (sonic-net#402) Update README.test.md [bgp_speaker]: always clean up test environment after it finishes (sonic-net#406) [vlan]: add vlan test to test by testname (sonic-net#408) [bug]: convert the interface from unicode to string (sonic-net#407) [VLAN test] Add VLAN test (sonic-net#375) [vm]: change the default Front plane port to 4 instead of 8 (sonic-net#404) Update README.testbed.Setup.md [acl]: Adopt tests with acl-loader to t0 and t1-lag topo. (sonic-net#370) add connect_topo command for testbed-cli.sh (sonic-net#398) [FIB, BGP speaker] fix t0-116 topology source port list (sonic-net#396) [bgp_speaker]: Specify VLAN IP route in case LPM to other nexthop (sonic-net#394) [sensor]: Change sensor labels for Arista 7050 and 7260 (sonic-net#395) Delete Arista DPMs sensors data (sonic-net#393) [bug]: change maximum packet to 9114 to send in the mtu test (sonic-net#391)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Approach
How did you do it?
Ansible time could be cached, causing multiple consecutive tests using a same time stamp to create
log files and losing older log files.
Changing to local host time would make time stamp always unique.
How did you verify/test it?
I first noticed this issue when I use a script to execute a test case (e.g. fib) continuously, the log file name would be identical due to timestamp being identical for each test. After the fix, the log file names are always different.