Conversation
…ions - Remove redundant comments throughout workflow module - Use is_cancelled() instead of loading full state in execute_workflow loop - Combine tracker reads to reduce lock acquisitions - Add Debug impl for EventBus
Summary of ChangesHello @slin1237, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refactoring and optimizing the workflow engine within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a good cleanup of the workflow module by removing redundant comments and introduces some valuable micro-optimizations. The switch to is_cancelled() and combining tracker reads are solid improvements for performance and correctness. The addition of a Debug implementation for EventBus is also a nice touch for improving observability. I have one minor suggestion to make a piece of the new code even more idiomatic and slightly more performant.
| if let Some(ref step) = failed_step { | ||
| self.state_store.update(instance_id, |s| { | ||
| s.status = WorkflowStatus::Failed; | ||
| })?; | ||
|
|
||
| let failed_step = tracker.read().failed.iter().next().cloned(); | ||
| self.event_bus | ||
| .publish(WorkflowEvent::WorkflowFailed { | ||
| instance_id, | ||
| failed_step: failed_step.unwrap_or_else(|| StepId::new("unknown")), | ||
| failed_step: step.clone(), | ||
| error: "One or more steps failed".to_string(), |
There was a problem hiding this comment.
This is a good refactoring. To make it slightly more idiomatic and efficient, you can move the StepId out of the Option instead of borrowing it. This avoids the clone() call when publishing the WorkflowFailed event.
| if let Some(ref step) = failed_step { | |
| self.state_store.update(instance_id, |s| { | |
| s.status = WorkflowStatus::Failed; | |
| })?; | |
| let failed_step = tracker.read().failed.iter().next().cloned(); | |
| self.event_bus | |
| .publish(WorkflowEvent::WorkflowFailed { | |
| instance_id, | |
| failed_step: failed_step.unwrap_or_else(|| StepId::new("unknown")), | |
| failed_step: step.clone(), | |
| error: "One or more steps failed".to_string(), | |
| if let Some(step) = failed_step { | |
| self.state_store.update(instance_id, |s| { | |
| s.status = WorkflowStatus::Failed; | |
| })?; | |
| self.event_bus | |
| .publish(WorkflowEvent::WorkflowFailed { | |
| instance_id, | |
| failed_step: step, | |
| error: "One or more steps failed".to_string(), |
…n_eagle3_npu * 'main' of https://github.com/sgl-project/sglang: (121 commits) Super tiny add gsp-fast-prepare (sgl-project#14992) Super tiny fix confusing slash_command_handler hint (sgl-project#14976) Super tiny remove unused argument (sgl-project#14966) [registry] Add a strict mode to model registration (sgl-project#14933) Feature/Fix multi lora scheduler blocking issue and evict LoRA None lastly (sgl-project#14795) Tune triton fused moe for the case of glm-4.6-fp8 b200 tp4 (sgl-project#15020) [model-gateway] refactor: unify worker management into modular workflow structure (sgl-project#15010) Update ci permission (sgl-project#15014) Refactor of http and engine entrypoints to allow custom override (sgl-project#14869) Add KV4-capable backend flashmla and update server args (sgl-project#14989) Revert several PRs (sgl-project#14958) Super tiny extract route_typed_request_once (sgl-project#14951) Fix CI by reverting incorrect metric check logic (sgl-project#15004) [model-gateway] refactor: workflow engine cleanup and minor optimization (sgl-project#15001) [model-gateway] fix: handle workflow deadlock and optimize cycle detection (sgl-project#15000) [model-gateway] feat: add DAG parallel execution support and workflow optimization (sgl-project#14999) [model-gateway] refactor: extract workflow engine to src/workflow module (sgl-project#14996) Update CODEOWNERS for multimodal_gen (sgl-project#14995) [diffusion] docker: Tiny fix Docker Hub link in installation documentation (sgl-project#14987) [PD] Add decode PP event loop for PD disaggregation (sgl-project#14945) ... # Conflicts: # python/sglang/srt/model_executor/piecewise_cuda_graph_runner.py
Checklist