[registry] Add a strict mode to model registration#14933
Merged
fzyzcjy merged 3 commits intosgl-project:mainfrom Dec 13, 2025
Merged
[registry] Add a strict mode to model registration#14933fzyzcjy merged 3 commits intosgl-project:mainfrom
fzyzcjy merged 3 commits intosgl-project:mainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
fzyzcjy
approved these changes
Dec 12, 2025
| @@ -19,8 +19,10 @@ class _ModelRegistry: | |||
| # Keyed by model_arch | |||
| models: Dict[str, Union[Type[nn.Module], str]] = field(default_factory=dict) | |||
|
|
|||
| def register(self, package_name: str, overwrite: bool = False): | |||
| new_models = import_model_classes(package_name) | |||
| def register( | |||
Collaborator
There was a problem hiding this comment.
optional nit: shall we enable strict mode by environ.py adding a env variable
Contributor
Author
There was a problem hiding this comment.
Oh i actually don't know what sglang folks prefer :)
Collaborator
There was a problem hiding this comment.
to be honest I also do not know :) I personally think making env var may be a little bit better b/c then people can use it w/o modifying register code
| @@ -100,6 +102,8 @@ def import_model_classes(package_name: str): | |||
| try: | |||
| module = importlib.import_module(name) | |||
| except Exception as e: | |||
| if strict: | |||
| raise e | |||
Collaborator
There was a problem hiding this comment.
tiny optional nit
Suggested change
| raise e | |
| raise |
(iirc raise e will lose trace)
| def register( | ||
| self, package_name: str, overwrite: bool = False, strict: bool = False | ||
| ): | ||
| new_models = import_model_classes(package_name, strict) |
Collaborator
There was a problem hiding this comment.
optional tiny nit
Suggested change
| new_models = import_model_classes(package_name, strict) | |
| new_models = import_model_classes(package_name, strict=strict) |
Collaborator
|
/tag-and-rerun-ci |
Collaborator
|
btw ping me on slack if I do not reply on gihub - I get too many messages everywhere and can miss things :( |
Liwansi
added a commit
to iforgetmyname/sglang
that referenced
this pull request
Dec 13, 2025
…n_eagle3_npu * 'main' of https://github.com/sgl-project/sglang: (121 commits) Super tiny add gsp-fast-prepare (sgl-project#14992) Super tiny fix confusing slash_command_handler hint (sgl-project#14976) Super tiny remove unused argument (sgl-project#14966) [registry] Add a strict mode to model registration (sgl-project#14933) Feature/Fix multi lora scheduler blocking issue and evict LoRA None lastly (sgl-project#14795) Tune triton fused moe for the case of glm-4.6-fp8 b200 tp4 (sgl-project#15020) [model-gateway] refactor: unify worker management into modular workflow structure (sgl-project#15010) Update ci permission (sgl-project#15014) Refactor of http and engine entrypoints to allow custom override (sgl-project#14869) Add KV4-capable backend flashmla and update server args (sgl-project#14989) Revert several PRs (sgl-project#14958) Super tiny extract route_typed_request_once (sgl-project#14951) Fix CI by reverting incorrect metric check logic (sgl-project#15004) [model-gateway] refactor: workflow engine cleanup and minor optimization (sgl-project#15001) [model-gateway] fix: handle workflow deadlock and optimize cycle detection (sgl-project#15000) [model-gateway] feat: add DAG parallel execution support and workflow optimization (sgl-project#14999) [model-gateway] refactor: extract workflow engine to src/workflow module (sgl-project#14996) Update CODEOWNERS for multimodal_gen (sgl-project#14995) [diffusion] docker: Tiny fix Docker Hub link in installation documentation (sgl-project#14987) [PD] Add decode PP event loop for PD disaggregation (sgl-project#14945) ... # Conflicts: # python/sglang/srt/model_executor/piecewise_cuda_graph_runner.py
Prozac614
pushed a commit
to Prozac614/sglang
that referenced
this pull request
Dec 17, 2025
YChange01
pushed a commit
to YChange01/sglang
that referenced
this pull request
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The default behavior of model registration is to warn if import model failed. This is a bit inconvenient sometimes as downstream error can be obscure and the original import warning is swallowed by wall of logs. Adding a strict mode to fail fast. This PR does not change default behavior.
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist