Update CODEOWNERS for multimodal_gen#14995
Conversation
Summary of ChangesHello @mickqian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintenance and minor quality-of-life improvements within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
d252b81 to
992cc44
Compare
There was a problem hiding this comment.
Code Review
This pull request includes several code cleanup, refactoring, and minor adjustment changes. It updates the .github/CODEOWNERS file to add a new owner for the multimodal_gen path. Logging configurations for uvicorn.run calls in http_server.py and launch_server.py were modified to enable colored output. In layernorm.py, unused platform-specific checks and imports were removed. The component_loader.py file saw refactoring where a standalone load_native function was inlined into a class method, and several verbose logging statements were removed or refined. The scheduling_flow_unipc_multistep.py file was cleaned up by removing unused methods like _sigma_to_t and __len__, along with some related variable calculations. A redundant logging statement was also removed from composed_pipeline_base.py. In perf_logger.py, print statements were replaced with logger.info and logger.error for performance metric dumping, standardizing the logging approach. Lastly, the run_suite.py file increased the max_retries for pytest from 2 to 4, and perf_baselines.json was updated with new performance baseline values for ImageVAEEncodingStage and expected_e2e_ms.
992cc44 to
12d913e
Compare
…n_eagle3_npu * 'main' of https://github.com/sgl-project/sglang: (121 commits) Super tiny add gsp-fast-prepare (sgl-project#14992) Super tiny fix confusing slash_command_handler hint (sgl-project#14976) Super tiny remove unused argument (sgl-project#14966) [registry] Add a strict mode to model registration (sgl-project#14933) Feature/Fix multi lora scheduler blocking issue and evict LoRA None lastly (sgl-project#14795) Tune triton fused moe for the case of glm-4.6-fp8 b200 tp4 (sgl-project#15020) [model-gateway] refactor: unify worker management into modular workflow structure (sgl-project#15010) Update ci permission (sgl-project#15014) Refactor of http and engine entrypoints to allow custom override (sgl-project#14869) Add KV4-capable backend flashmla and update server args (sgl-project#14989) Revert several PRs (sgl-project#14958) Super tiny extract route_typed_request_once (sgl-project#14951) Fix CI by reverting incorrect metric check logic (sgl-project#15004) [model-gateway] refactor: workflow engine cleanup and minor optimization (sgl-project#15001) [model-gateway] fix: handle workflow deadlock and optimize cycle detection (sgl-project#15000) [model-gateway] feat: add DAG parallel execution support and workflow optimization (sgl-project#14999) [model-gateway] refactor: extract workflow engine to src/workflow module (sgl-project#14996) Update CODEOWNERS for multimodal_gen (sgl-project#14995) [diffusion] docker: Tiny fix Docker Hub link in installation documentation (sgl-project#14987) [PD] Add decode PP event loop for PD disaggregation (sgl-project#14945) ... # Conflicts: # python/sglang/srt/model_executor/piecewise_cuda_graph_runner.py
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist