Skip to content

Avoid Travis failure regarding skimage.lookfor#3477

Merged
stefanv merged 4 commits intoscikit-image:masterfrom
sciunto:cython_version
Oct 17, 2018
Merged

Avoid Travis failure regarding skimage.lookfor#3477
stefanv merged 4 commits intoscikit-image:masterfrom
sciunto:cython_version

Conversation

@sciunto
Copy link
Copy Markdown
Member

@sciunto sciunto commented Oct 16, 2018 •
edited
Loading

Description

Workaround until #3475 is fixed.

Checklist

[It's fine to submit PRs which are a work in progress! But before they are merged, all PRs should provide:]

[For detailed information on these and other aspects see scikit-image contribution guidelines]

References

[If this is a bug-fix or enhancement, it closes issue # ]
[If this is a new feature, it implements the following paper: ]

For reviewers

(Don't remove the checklist below.)

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

@sciunto sciunto changed the title WIP: avoid travis failture regarding scikit.lookfor Avoid travis failture regarding scikit.lookfor Oct 16, 2018
@sciunto sciunto assigned jni and unassigned jni Oct 16, 2018
jni
jni approved these changes Oct 16, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to merge, I'm just going to ask:

  1. should it not be <0.29? I think we were using 0.28 for a long time before this?
  2. possibly the "right" way of doing this is to have an "allowed fail" build in Travis https://docs.travis-ci.com/user/customizing-the-build/#rows-that-are-allowed-to-fail so that we at least know when Cython gets fixed. But that can wait.

@sciunto
Copy link
Copy Markdown
Member Author

sciunto commented Oct 16, 2018

Regarding 1.: you said that it failed with "0.28.2". I chose to disregard all subversions from 0.28.x.

  1. hum, yes, but I'm not on the way to do it shortly.

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Oct 16, 2018

AFAIK, cython 0.27 is incompatible with python 3.7

@sciunto
Copy link
Copy Markdown
Member Author

sciunto commented Oct 16, 2018

But the test suite passes with python 3.7. It's all we need for this temporary patch.

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Oct 16, 2018

Right, but I have a feeling it is only 0.28.2 that was buggy.

See #3455
that passed with 0.28.5
https://travis-ci.org/scikit-image/scikit-image/jobs/438951025#L2581

Worth a try with !=0.29.0

@hmaarrfk
Copy link
Copy Markdown
Member

hmaarrfk commented Oct 16, 2018

This is awesome! thanks for looking it to this. It seems that both 0.28.2 and 0.29.0 were buggy! luck is just not on @jni's side 😆

@jni
Copy link
Copy Markdown
Member

jni commented Oct 16, 2018

Note that, except for a stalled build (which I just restarted), !=0.29.0 actually passed:

https://travis-ci.org/scikit-image/scikit-image/builds/442325025

ditto for AppVeyor:

https://ci.appveyor.com/project/scikit-image/scikit-image/builds/19558108

@stefanv stefanv merged commit a9b4654 into scikit-image:master Oct 17, 2018
@hmaarrfk hmaarrfk mentioned this pull request Oct 17, 2018
Merged
4 tasks
@sciunto sciunto deleted the cython_version branch October 28, 2018 10:55
@sciunto sciunto changed the title Avoid travis failture regarding scikit.lookfor Avoid travis failure regarding scikit.lookfor Oct 28, 2018
@sciunto
Copy link
Copy Markdown
Member Author

sciunto commented Nov 11, 2018

@meeseeksdev backport to v0.14.x

@meeseeksmachine meeseeksmachine mentioned this pull request Nov 11, 2018
Merged
meeseeksmachine pushed a commit to meeseeksmachine/scikit-image that referenced this pull request Nov 11, 2018
@sciunto
Backport PR scikit-image#3477: Avoid travis failure regarding scikit.…
ac9679f 
…lookfor
@lagru lagru mentioned this pull request Nov 14, 2018
Merged
9 tasks
sciunto added a commit that referenced this pull request Nov 17, 2018
@sciunto
Merge pull request #3543 from meeseeksmachine/auto-backport-of-pr-347…
7a12bc0 
…7-on-v0.14.x

Backport PR #3477 on branch v0.14.x (Avoid travis failure regarding scikit.lookfor)
@soupault soupault changed the title Avoid travis failure regarding scikit.lookfor Avoid Travis failure regarding skimage.lookfor Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jni jni jni approved these changes

Assignees

@jni jni

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sciunto @hmaarrfk @jni @stefanv