Skip to content

Improvement: TST: numpy empty arrays are not inherently Falsy#3455

Merged
sciunto merged 1 commit intoscikit-image:masterfrom
hmaarrfk:numpy_empty_arrays_are_not_falsy
Oct 9, 2018
Merged

Improvement: TST: numpy empty arrays are not inherently Falsy#3455
sciunto merged 1 commit intoscikit-image:masterfrom
hmaarrfk:numpy_empty_arrays_are_not_falsy

Conversation

@hmaarrfk
Copy link
Copy Markdown
Member

@hmaarrfk hmaarrfk commented Oct 9, 2018

As explained by a warning

For reviewers

  • Check that the PR title is short, concise, and will make sense 1 year
    later.
  • Check that new functions are imported in corresponding __init__.py.
  • Check that new features, API changes, and deprecations are mentioned in
    doc/release/release_dev.rst.
  • Consider backporting the PR with @meeseeksdev backport to v0.14.x

jni
jni approved these changes Oct 9, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@jni jni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io

This comment has been minimized.

Sign in to view
@sciunto sciunto merged commit 942ed29 into scikit-image:master Oct 9, 2018
@sciunto
Copy link
Copy Markdown
Member

sciunto commented Oct 9, 2018

Thanks!

@hmaarrfk hmaarrfk mentioned this pull request Oct 16, 2018
Merged
9 tasks
@hmaarrfk hmaarrfk deleted the numpy_empty_arrays_are_not_falsy branch November 4, 2018 13:27
@hmaarrfk hmaarrfk changed the title TST: numpy empty arrays are not inherently Falsy Improvement: TST: numpy empty arrays are not inherently Falsy Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jni jni jni approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hmaarrfk @codecov-io @sciunto @jni