Skip to content

Backport PR #3477 on branch v0.14.x (Avoid travis failure regarding scikit.lookfor)#3543

Merged
sciunto merged 1 commit intoscikit-image:v0.14.xfrom
meeseeksmachine:auto-backport-of-pr-3477-on-v0.14.x
Nov 17, 2018
Merged

Backport PR #3477 on branch v0.14.x (Avoid travis failure regarding scikit.lookfor)#3543
sciunto merged 1 commit intoscikit-image:v0.14.xfrom
meeseeksmachine:auto-backport-of-pr-3477-on-v0.14.x

Conversation

@meeseeksmachine
Copy link
Copy Markdown

Backport PR #3477: Avoid travis failure regarding scikit.lookfor

@sciunto sciunto added this to the 0.14.2 milestone Nov 11, 2018
@jni
Copy link
Copy Markdown
Member

jni commented Nov 12, 2018

For some reason this appears to have failed on Python 3.x?

@hmaarrfk
Copy link
Copy Markdown
Member

I think you need a few more PRs:
See current line
https://github.com/scikit-image/scikit-image/blob/master/requirements/build.txt#L1

@hmaarrfk
Copy link
Copy Markdown
Member

Though i guess your rule does capture both of those :/

@hmaarrfk
Copy link
Copy Markdown
Member

Cython version isn't being respected :/

https://travis-ci.org/scikit-image/scikit-image/jobs/453561833#L847

@sciunto
Copy link
Copy Markdown
Member

sciunto commented Nov 17, 2018

i made some investigations. It's due to this: https://github.com/scikit-image/scikit-image/blob/v0.14.x/tools/travis/before_install.sh#L52

@sciunto
Copy link
Copy Markdown
Member

sciunto commented Nov 17, 2018

I merge and backport another PR that should to the job.

@sciunto sciunto merged commit 7a12bc0 into scikit-image:v0.14.x Nov 17, 2018
@sciunto
Copy link
Copy Markdown
Member

sciunto commented Nov 17, 2018

We must merge this in v0.14.x #3227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants