Skip to content

Only lint unused features if they are unstable#153610

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
mu001999-contrib:fix/unused-stable-features
Mar 10, 2026
Merged

Only lint unused features if they are unstable#153610
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
mu001999-contrib:fix/unused-stable-features

Conversation

@mu001999
Copy link
Contributor

@mu001999 mu001999 commented Mar 9, 2026

Fixes #153523

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2026
@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 16 candidates

@mu001999 mu001999 changed the title Only lint unused unstable features Only lint unused features if they are unstable Mar 9, 2026
@mu001999 mu001999 force-pushed the fix/unused-stable-features branch from 040d717 to 2c7690e Compare March 9, 2026 15:36
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@nbdd0121 nbdd0121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a much cleaner solution.

View changes since this review

Copy link
Contributor

@JonathanBrouwer JonathanBrouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thansk for the quick fix!

@bors r+ rollup

View changes since this review

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

📌 Commit dfd5e90 has been approved by JonathanBrouwer

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2026
…-features, r=JonathanBrouwer

Only lint unused features if they are unstable

Fixes rust-lang#153523
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
Rollup of 8 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #149931 (rustdoc: don't give depreciation notes special handling)
 - #153608 (ast_passes: unsupported arch w/ scalable vectors)
 - #153609 (Add missing `Diag::with_span_suggestion_with_style` method)
 - #153610 (Only lint unused features if they are unstable)
 - #153616 (Update `sysinfo` version to `0.38.4`)
 - #153619 (Update books)
 - #153624 (Ping fmease on parser modifications)
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
Rollup of 7 pull requests

Successful merges:

 - #149931 (rustdoc: don't give depreciation notes special handling)
 - #153608 (ast_passes: unsupported arch w/ scalable vectors)
 - #153609 (Add missing `Diag::with_span_suggestion_with_style` method)
 - #153610 (Only lint unused features if they are unstable)
 - #153616 (Update `sysinfo` version to `0.38.4`)
 - #153619 (Update books)
 - #153624 (Ping fmease on parser modifications)
@rust-bors rust-bors bot merged commit 1aeecf0 into rust-lang:main Mar 10, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 10, 2026
rust-timer added a commit that referenced this pull request Mar 10, 2026
Rollup merge of #153610 - mu001999-contrib:fix/unused-stable-features, r=JonathanBrouwer

Only lint unused features if they are unstable

Fixes #153523
@mu001999 mu001999 deleted the fix/unused-stable-features branch March 10, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unused_features triggers on stable lint_reasons despite usage

5 participants