Skip to content

ast_passes: unsupported arch w/ scalable vectors#153608

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
davidtwco:sve-unsupported-architecture
Mar 10, 2026
Merged

ast_passes: unsupported arch w/ scalable vectors#153608
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
davidtwco:sve-unsupported-architecture

Conversation

@davidtwco
Copy link
Member

@davidtwco davidtwco commented Mar 9, 2026

Fixes #153593

Emit an error when attempting to compile a #[rustc_scalable_vector] type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this.

r? @lqd

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

@rustbot rustbot added A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 9, 2026
@rust-log-analyzer

This comment has been minimized.

//@ ignore-riscv64
//@ check-fail

// Confirm that non-AArch64 and non-RISC-V targets error when compiling scalable vectors
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we just mention #153593 here

Copy link
Member

@lqd lqd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking whether a target spec supports the feature makes sense to me (though I haven't checked if we do that with other targets per se).

r=me with nits above

View changes since this review

@davidtwco davidtwco force-pushed the sve-unsupported-architecture branch 3 times, most recently from 65eb291 to 9eb35b1 Compare March 9, 2026 15:12
Emit an error when attempting to compile a `#[rustc_scalable_vector]`
type for a architecture that fundamentally doesn't support scalable
vectors. Ultimately this is just a diagnostic improvement for an internal
attribute as users should never be doing this.
@davidtwco davidtwco force-pushed the sve-unsupported-architecture branch from 9eb35b1 to 342ad04 Compare March 9, 2026 15:13
@davidtwco
Copy link
Member Author

@bors r=lqd rollup+

@rust-bors
Copy link
Contributor

rust-bors bot commented Mar 9, 2026

📌 Commit 342ad04 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2026
@lqd
Copy link
Member

lqd commented Mar 9, 2026

@bors rollup=always

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 9, 2026
…ture, r=lqd

ast_passes: unsupported arch w/ scalable vectors

Fixes rust-lang#153593

Emit an error when attempting to compile a `#[rustc_scalable_vector]` type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this.

r? @lqd
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
…uwer

Rollup of 5 pull requests

Successful merges:

 - #153283 (feat(rustdoc-json): Add optional support for rkyv (de)serialization)
 - #153608 (ast_passes: unsupported arch w/ scalable vectors)
 - #153616 (Update `sysinfo` version to `0.38.4`)
 - #153619 (Update books)
 - #153624 (Ping fmease on parser modifications)
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 9, 2026
…ture, r=lqd

ast_passes: unsupported arch w/ scalable vectors

Fixes rust-lang#153593

Emit an error when attempting to compile a `#[rustc_scalable_vector]` type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this.

r? @lqd
rust-bors bot pushed a commit that referenced this pull request Mar 9, 2026
Rollup of 8 pull requests

Successful merges:

 - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.)
 - #149931 (rustdoc: don't give depreciation notes special handling)
 - #153608 (ast_passes: unsupported arch w/ scalable vectors)
 - #153609 (Add missing `Diag::with_span_suggestion_with_style` method)
 - #153610 (Only lint unused features if they are unstable)
 - #153616 (Update `sysinfo` version to `0.38.4`)
 - #153619 (Update books)
 - #153624 (Ping fmease on parser modifications)
rust-bors bot pushed a commit that referenced this pull request Mar 10, 2026
Rollup of 7 pull requests

Successful merges:

 - #149931 (rustdoc: don't give depreciation notes special handling)
 - #153608 (ast_passes: unsupported arch w/ scalable vectors)
 - #153609 (Add missing `Diag::with_span_suggestion_with_style` method)
 - #153610 (Only lint unused features if they are unstable)
 - #153616 (Update `sysinfo` version to `0.38.4`)
 - #153619 (Update books)
 - #153624 (Ping fmease on parser modifications)
@rust-bors rust-bors bot merged commit 578d299 into rust-lang:main Mar 10, 2026
11 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Mar 10, 2026
rust-timer added a commit that referenced this pull request Mar 10, 2026
Rollup merge of #153608 - davidtwco:sve-unsupported-architecture, r=lqd

ast_passes: unsupported arch w/ scalable vectors

Fixes #153593

Emit an error when attempting to compile a `#[rustc_scalable_vector]` type for a architecture that fundamentally doesn't support scalable vectors. Ultimately this is just a diagnostic improvement for an internal attribute as users should never be doing this.

r? @lqd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

4 participants