Skip to content

Conversation

@lolbinarycat
Copy link
Contributor

@lolbinarycat lolbinarycat commented Dec 12, 2025

based on discussion in #149741

we're currently using pre-wrap here which forces us to do a bunch of other hacky weird stuff, but getting rid of all that would likely break some existing docs, so i'm proposing we do it across an edition.

r? @GuillaumeGomez

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @lolbinarycat

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 12, 2025
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Dec 12, 2025
@yotamofek
Copy link
Contributor

Gonna let Guillaume r+, but looks good to me!

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez
Copy link
Member

Just commented about this here. I'd personally just make the update without gating it behind next edition but seems like something worth discussing with the rest of the team.

@bors
Copy link
Collaborator

bors commented Jan 7, 2026

☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts.

1 similar comment
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 7, 2026

☔ The latest upstream changes (presumably #150645) made this pull request unmergeable. Please resolve the merge conflicts.

@lolbinarycat
Copy link
Contributor Author

This was discussed in this month's t-rustdoc meeting, the consensus was the edition gating should be removed and the "future edition" behavior should apply to all editions.

@lolbinarycat lolbinarycat changed the title rustdoc: don't give depreciation notes special handling in future edition rustdoc: don't give depreciation notes special handling Jan 14, 2026
@lolbinarycat lolbinarycat force-pushed the rustdoc-depr-html-future branch from fdb1d6e to 88d9df0 Compare January 14, 2026 22:22
@rustbot rustbot added the A-rustdoc-js Area: Rustdoc's JS front-end label Jan 14, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 14, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@rust-log-analyzer
Copy link
Collaborator

The job aarch64-gnu-llvm-20-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
failures:

---- html::markdown::tests::test_markdown_html_escape stdout ----

thread 'html::markdown::tests::test_markdown_html_escape' (58277) panicked at src/librustdoc/html/markdown/tests.rs:475:9:
assertion `left == right` failed: original: `Struct<'a, T>`
  left: "<p><code>Struct&lt;'a, T&gt;</code></p>\n"
 right: "<p><code>Struct&lt;'a, T&gt;</code></p>"
stack backtrace:
   0: __rustc::rust_begin_unwind
   1: core::panicking::panic_fmt
   2: core::panicking::assert_failed_inner
   3: core::panicking::assert_failed::<alloc::string::String, alloc::string::String>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-rustdoc-js Area: Rustdoc's JS front-end S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants