Add missing Diag::with_span_suggestion_with_style method#153609
Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom Mar 10, 2026
Merged
Add missing Diag::with_span_suggestion_with_style method#153609rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Diag::with_span_suggestion_with_style method#153609rust-bors[bot] merged 2 commits intorust-lang:mainfrom
Conversation
JonathanBrouwer
approved these changes
Mar 9, 2026
Contributor
There was a problem hiding this comment.
Can you also fix the FIXME's you left in #153509?
c66457e to
a4a37ed
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Member
Author
|
Now that the original PR has been merged, rebased and updated the code. :) |
JonathanBrouwer
approved these changes
Mar 9, 2026
Contributor
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 9, 2026
…n_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on rust-lang#153509. r? @JonathanBrouwer
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 9, 2026
Rollup of 8 pull requests Successful merges: - #148562 (In `Option::get_or_insert_with()`, forget the `None` instead of dropping it.) - #149931 (rustdoc: don't give depreciation notes special handling) - #153608 (ast_passes: unsupported arch w/ scalable vectors) - #153609 (Add missing `Diag::with_span_suggestion_with_style` method) - #153610 (Only lint unused features if they are unstable) - #153616 (Update `sysinfo` version to `0.38.4`) - #153619 (Update books) - #153624 (Ping fmease on parser modifications)
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Rollup of 7 pull requests Successful merges: - #149931 (rustdoc: don't give depreciation notes special handling) - #153608 (ast_passes: unsupported arch w/ scalable vectors) - #153609 (Add missing `Diag::with_span_suggestion_with_style` method) - #153610 (Only lint unused features if they are unstable) - #153616 (Update `sysinfo` version to `0.38.4`) - #153619 (Update books) - #153624 (Ping fmease on parser modifications)
rust-timer
added a commit
that referenced
this pull request
Mar 10, 2026
Rollup merge of #153609 - GuillaumeGomez:with_span_suggestion_with_style, r=JonathanBrouwer Add missing `Diag::with_span_suggestion_with_style` method Uncovered while working on #153509. r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uncovered while working on #153509.
r? @JonathanBrouwer