removed dependency to ros1_bridge package#90
Conversation
* checking if package is available * if not skipping (with warnings) * now rosbag2_tests builds on systems without ros1
|
@DensoADAS thanks for the patch. I hope you don't mind me editing your original description for this PR. I connected it to the open issue so that our waffle board picks it up correctly and automatically closes the referenced issue when this PR is merged. extremely helpful patch. Running CI on it:
I believe the cmake warning has to be turned into |
|
new round of CI, disabling
that being said, I would really appreciate if we could use this PR to extend the same logic to the two excluded packages so that this complete repo can actually be built without any ros1 dependency. |
|
Looking at the latest CI, this patch is not sufficient. Looks like we should patch the two packages in question as well in . order to run CI correctly. |
check ros1 deps correctly on all packages
|
depends on ros2/ros1_bridge#164 |
| message(WARNING "Failed to find PkgConfig, skipping...") | ||
| # include bridge first to not create package if ros1 packages cannot be found | ||
| find_package(ros1_bridge QUIET) | ||
| if (NOT ros1_bridge_FOUND) |
There was a problem hiding this comment.
| if (NOT ros1_bridge_FOUND) | |
| if(NOT ros1_bridge_FOUND) |
Karsten1987
left a comment
There was a problem hiding this comment.
there is one linter error left in the patch. If you'd accept the suggestion we should be good to go.
Sorry for the long turnover time here, I struggled to set up a suitable CI job for this. Here it is:
* removed dependency to ros1_bridge package (#90) * removed dependency to ros1_bridge package: * checking if package is available * if not skipping (with warnings) * now rosbag2_tests builds on systems without ros1 * check ros1 deps correctly on all packages * add ros1_bridge to test package * silently try to find the bridge * correct missing linter errors (#96) Signed-off-by: Karsten Knese <karsten@openrobotics.org>
fixes #85
removed dependency to ros1_bridge package: