Merged
Conversation
Signed-off-by: Karsten Knese <karsten@openrobotics.org>
Karsten1987
added a commit
that referenced
this pull request
Apr 8, 2019
* removed dependency to ros1_bridge package (#90) * removed dependency to ros1_bridge package: * checking if package is available * if not skipping (with warnings) * now rosbag2_tests builds on systems without ros1 * check ros1 deps correctly on all packages * add ros1_bridge to test package * silently try to find the bridge * correct missing linter errors (#96) Signed-off-by: Karsten Knese <karsten@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for visibility only. Merging straight ahead.
connects to #90 (comment)
Signed-off-by: Karsten Knese karsten@openrobotics.org