Skip to content

[foxy] Copy recorder QoS profile to local variable so that temporary value isn't cleared (backport #803)#1335

Merged
MichaelOrlov merged 1 commit intofoxyfrom
mergify/bp/foxy/pr-803
May 16, 2023
Merged

[foxy] Copy recorder QoS profile to local variable so that temporary value isn't cleared (backport #803)#1335
MichaelOrlov merged 1 commit intofoxyfrom
mergify/bp/foxy/pr-803

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented May 16, 2023

This is an automatic backport of pull request #803 done by Mergify.
Cherry-pick of 8234765 has failed:

On branch mergify/bp/foxy/pr-803
Your branch is up to date with 'origin/foxy'.

You are currently cherry-picking commit 8234765.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   rosbag2_transport/src/rosbag2_transport/recorder.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot added the conflicts label May 16, 2023
@mergify mergify bot mentioned this pull request May 16, 2023
Merged
@MichaelOrlov MichaelOrlov changed the title Copy recorder QoS profile to local variable so that temporary value isn't cleared (backport #803) [foxy] Copy recorder QoS profile to local variable so that temporary value isn't cleared (backport #803) May 16, 2023
@morlov-apexai
Copy recorder QoS profile to local variable so that temporary value i…
858d585 
…sn't cleared (#803)

Co-authored-by: Emerson Knapp <eknapp@amazon.com>
Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
(cherry picked from commit 8234765)
@MichaelOrlov MichaelOrlov force-pushed the mergify/bp/foxy/pr-803 branch from f488379 to 858d585 Compare May 16, 2023 18:54
@MichaelOrlov
Copy link
Copy Markdown
Contributor

MichaelOrlov commented May 16, 2023

Gist: https://gist.githubusercontent.com/MichaelOrlov/a284e120dd2fd4cf6909edf01a2c6215/raw/ab2f97c7b0a1e89f9451d6b37a98edff131c3c92/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_transport
TEST args: --packages-above rosbag2_transport
ROS Distro: foxy
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/12073

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov MichaelOrlov mentioned this pull request May 16, 2023
Closed
@MichaelOrlov MichaelOrlov added the bug Something isn't working label May 16, 2023
@MichaelOrlov MichaelOrlov linked an issue May 16, 2023 that may be closed by this pull request
ros2 bag record: Implausible warnings #1332
Closed
@MichaelOrlov
Copy link
Copy Markdown
Contributor

MichaelOrlov commented May 16, 2023

Re-run CI with focal distro

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@MichaelOrlov
Copy link
Copy Markdown
Contributor

MichaelOrlov commented May 16, 2023

Windows build failed due to the issue in build infrastructure



  Checking Build System

  Building Custom Rule C:/ci/ws/src/ros2/rosidl_typesupport_connext/rosidl_typesupport_connext_cpp/CMakeLists.txt

  identifier.cpp

  wstring_conversion.cpp

     Creating library C:/ci/ws/build/rosidl_typesupport_connext_cpp/Release/rosidl_typesupport_connext_cpp.lib and object C:/ci/ws/build/rosidl_typesupport_connext_cpp/Release/rosidl_typesupport_connext_cpp.exp

CVTRES : fatal error CVT1107: 'C:\Program Files\rti_connext_dds-5.3.1\lib\x64Win64VS2017\nddscpp.lib' is corrupt [C:\ci\ws\build\rosidl_typesupport_connext_cpp\rosidl_typesupport_connext_cpp.vcxproj]

LINK : fatal error LNK1123: failure during conversion to COFF: file invalid or corrupt [C:\ci\ws\build\rosidl_typesupport_connext_cpp\rosidl_typesupport_connext_cpp.vcxproj]

---
--- stderr: rosidl_typesupport_connext_cpp
CMake Warning (dev) at C:/ci/ws/install/share/connext_cmake_module/cmake/Modules/FindConnext.cmake:163 (list):
  Policy CMP0121 is not set: The list() command now validates parsing of
  index arguments.  Run "cmake --help-policy CMP0121" for policy details.
  Use the cmake_policy command to set the policy and suppress this warning.
  Invalid list index "nddsc.lib".
Call Stack (most recent call first):
  C:/ci/ws/install/share/connext_cmake_module/cmake/Modules/FindConnext.cmake:198 (_count_found_libraries)
  CMakeLists.txt:25 (find_package)

@MichaelOrlov MichaelOrlov merged commit 9e001ec into foxy May 16, 2023
@delete-merged-branch delete-merged-branch bot deleted the mergify/bp/foxy/pr-803 branch May 16, 2023 23:07
MichaelOrlov pushed a commit that referenced this pull request May 24, 2023
@morlov-apexai
Fix for CI regression in TestRos2BagRecord
f50f46a 
- Replace get_actual_qos() to the qos_profile() as it was before #1335
For some reason on Foxy it doesn't work as expected. Probably due to the
missing some underlying dependencies in other core packages.

Signed-off-by: Michael <michael.orlov@apex.ai>
@MichaelOrlov MichaelOrlov mentioned this pull request May 24, 2023
Merged
MichaelOrlov pushed a commit that referenced this pull request May 25, 2023
@morlov-apexai
Fix for CI regression in TestRos2BagRecord
921a4ef 
- Replace get_actual_qos() to the qos_profile() as it was before #1335
For some reason on Foxy it doesn't work as expected. Probably due to the
missing some underlying dependencies in other core packages.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
MichaelOrlov pushed a commit that referenced this pull request May 25, 2023
@morlov-apexai
[foxy] Disable test_record_qos_profiles tests on Windows (#1349)
3405be1 
* Fix for CI regression in TestRos2BagRecord

- Replace get_actual_qos() to the qos_profile() as it was before #1335
For some reason on Foxy it doesn't work as expected. Probably due to the
missing some underlying dependencies in other core packages.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Revert "Fix for CI regression in TestRos2BagRecord"

This reverts commit f50f46a.

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

* Skip test_record_qos_profiles on Windows since they are flaky

- test_record_qos_profiles failures is a known issue described in the
#454
- To fix those tests need to backport #462, #466, #470, #472, #525
- Skipping them for a while

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>

---------

Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MichaelOrlov MichaelOrlov MichaelOrlov approved these changes

Assignees

No one assigned

Labels

bug Something isn't working conflicts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ros2 bag record: Implausible warnings

2 participants

@MichaelOrlov @morlov-apexai