use a single temp dir for the test class#462
Merged
dirk-thomas merged 1 commit intomasterfrom Jul 15, 2020
Merged
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
dirk-thomas
commented
Jul 15, 2020
| r"ros2 bag record: error: argument --qos-profile-overrides-path: can't open") | ||
| matches = expected_string_regex.search(bag_command.output) | ||
| assert matches, print('ros2bag CLI did not produce the expected output') | ||
| output_path = Path(self.tmpdir.name) / 'ros2bag_test_nonexistent' |
Member
Author
There was a problem hiding this comment.
Here I changed the name of the subdirectory which wasn't unique and looked like a copy-n-paste mistake.
Karsten1987
approved these changes
Jul 15, 2020
Collaborator
Karsten1987
left a comment
There was a problem hiding this comment.
changes look clear to me. Waiting on CI to see that no regression got introduced on other platforms:
- Linux
- Linux-aarch64
- macOS
- Windows
Collaborator
|
thanks for the fix! |
dirk-thomas
added a commit
that referenced
this pull request
Jul 16, 2020
This reverts commit a67ed49.
Member
Author
|
This only made the test less flaky on Windows. There is still a race - see #466. |
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
* Fix for CI regression in TestRos2BagRecord - Replace get_actual_qos() to the qos_profile() as it was before #1335 For some reason on Foxy it doesn't work as expected. Probably due to the missing some underlying dependencies in other core packages. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Revert "Fix for CI regression in TestRos2BagRecord" This reverts commit f50f46a. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Skip test_record_qos_profiles on Windows since they are flaky - test_record_qos_profiles failures is a known issue described in the #454 - To fix those tests need to backport #462, #466, #470, #472, #525 - Skipping them for a while Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #454: https://ci.ros2.org/view/nightly/job/nightly_win_rel/1613/testReport/ros2bag.test/test_record_qos_profiles/test_record_qos_profiles/
The diff ignoring whitespace changes is much easier to read: https://github.com/ros2/rosbag2/pull/462/files?w=1