Merged
Conversation
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
Member
Author
|
The failing test in the PR build seems unrelated to this change. |
Member
Author
|
This Windows build shows no test failure anymore: |
Karsten1987
approved these changes
Jul 24, 2020
emersonknapp
pushed a commit
that referenced
this pull request
Feb 2, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
emersonknapp
pushed a commit
that referenced
this pull request
Feb 17, 2021
Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
MichaelOrlov
pushed a commit
that referenced
this pull request
May 25, 2023
* Fix for CI regression in TestRos2BagRecord - Replace get_actual_qos() to the qos_profile() as it was before #1335 For some reason on Foxy it doesn't work as expected. Probably due to the missing some underlying dependencies in other core packages. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Revert "Fix for CI regression in TestRos2BagRecord" This reverts commit f50f46a. Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Skip test_record_qos_profiles on Windows since they are flaky - test_record_qos_profiles failures is a known issue described in the #454 - To fix those tests need to backport #462, #466, #470, #472, #525 - Skipping them for a while Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Michael Orlov <michael.orlov@apex.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #470.
I am not planning to run CI builds for this change since the PR build ensures that the syntax is valid.
A single Windows build won't say anything if this actually catches the problem in the test since this is subject to a race. Hopefully the next nightlies will show an improvement.