Copy recorder QoS profile to local variable so that temporary value isn't cleared#803
Merged
emersonknapp merged 1 commit intomasterfrom Jul 2, 2021
Merged
Conversation
…sn't cleared Signed-off-by: Emerson Knapp <eknapp@amazon.com>
This was referenced Jun 30, 2021
piraka9011
approved these changes
Jul 2, 2021
Contributor
piraka9011
left a comment
There was a problem hiding this comment.
Good to know about this behavior.
Note that this is the suggested usage in the release notes for ROS2 E here and is used in a similar manner in ros2/rclcpp
Collaborator
Author
|
Gist: https://gist.githubusercontent.com/emersonknapp/b7950c8a1ec619dc9e3a81d619059818/raw/0b1336f778774e97fa43f903388f4e42a120aa94/ros2.repos
|
emersonknapp
added a commit
that referenced
this pull request
Jul 2, 2021
…sn't cleared (#803) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
emersonknapp
added a commit
that referenced
this pull request
Jul 2, 2021
…sn't cleared (#803) Signed-off-by: Emerson Knapp <eknapp@amazon.com>
Contributor
|
https://github.com/Mergifyio backport foxy |
✅ Backports have been createdDetails
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #772
Fixes #802
This function was using a temporary variable that got cleared, and so had undefined behavior. Create a local variable to make the reference valid.