Skip to content

Added rmw_event_type_is_supported#250

Merged
ahcorde merged 4 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible
Mar 11, 2025
Merged

Added rmw_event_type_is_supported#250
ahcorde merged 4 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 5, 2025

Related with this issue ros2/rmw#394. Check if a event is supported by the rmw

@ahcorde
Added rmw_event_check_compatible
bbf6c0b 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund March 5, 2025 13:48
@ahcorde ahcorde self-assigned this Mar 5, 2025
@ahcorde ahcorde mentioned this pull request Mar 5, 2025
Closed
@ahcorde
fix return typoe
7e729cd 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 6, 2025

Pulls: ros2/rmw#395, #250, ros2/rmw_cyclonedds#532, ros2/rmw_fastrtps#809, ros2/rmw_connextdds#173
Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Mar 6, 2025
Merged
Merged
Merged
Merged
@ahcorde ahcorde changed the title Added rmw_event_check_compatible Added rmw_event_type_is_supported Mar 6, 2025
ahcorde added 2 commits March 7, 2025 17:42
@ahcorde
updated name and use in wait_set test
1cd4dab 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Merge branch 'rolling' into ahcorde/rolling/rmw_event_check_compatible
950b1f5 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Windows CI failures are unrelated and failing aarch64 job is expected

@ahcorde ahcorde merged commit cdf7077 into rolling Mar 11, 2025
2 of 3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/rmw_event_check_compatible branch March 11, 2025 09:20
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 11, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details
  • Backport to branch jazzy not needed, change already in branch jazzy

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 11, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details
  • Backport to branch jazzy not needed, change already in branch jazzy

ahcorde added a commit that referenced this pull request Mar 11, 2025
@ahcorde
Added rmw_event_type_is_supported (#250)
b64c572 
* Added rmw_event_check_compatible

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* fix return typoe

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* updated name and use in wait_set test

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Something went wrong when I squash and merge this commit on Github, I created the backport manually #252

ahcorde added a commit that referenced this pull request Mar 12, 2025
@ahcorde
Added rmw_event_type_is_supported (#250) (#252)
6b93199 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
leeminju531 pushed a commit to leeminju531/rmw_implementation that referenced this pull request May 5, 2025
@ahcorde
Added rmw_event_type_is_supported (ros2#250)
f085598 
* Added rmw_event_check_compatible

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* fix return typoe

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* updated name and use in wait_set test

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @fujitatomoya