Skip to content

Added rmw_event_type_is_supported#809

Merged
ahcorde merged 6 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible
Mar 11, 2025
Merged

Added rmw_event_type_is_supported#809
ahcorde merged 6 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 5, 2025

Related with this issue ros2/rmw#394. Check if a event is supported by the rmw

@ahcorde
Added rmw_event_check_compatible
3e1ff3c 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 5, 2025
@ahcorde ahcorde requested a review from Yadunund March 5, 2025 13:49
@ahcorde ahcorde mentioned this pull request Mar 5, 2025
Closed
MiguelCompany
MiguelCompany requested changes Mar 5, 2025
View reviewed changes
@ahcorde
Fixed build
e8c79a6 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
MiguelCompany
MiguelCompany requested changes Mar 5, 2025
View reviewed changes
@ahcorde
included review feedback
6249501 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
MiguelCompany
MiguelCompany requested changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could not resist my OCD...

ahcorde and others added 2 commits March 6, 2025 10:20
@ahcorde
review feedback
037d718 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde @MiguelCompany
Update rmw_fastrtps_cpp/src/rmw_event.cpp
9465890 
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde mentioned this pull request Mar 6, 2025
Merged
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 6, 2025

Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, #809, ros2/rmw_connextdds#173
Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Mar 6, 2025
Merged
Merged
Merged
@MiguelCompany
Copy link
Copy Markdown
Collaborator

MiguelCompany commented Mar 6, 2025

Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, #809, ros2/rmw_connextdds#173 Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

You need to run CI manually, since rmw_fastrtps_dynamic_cpp is ignored by default

@ahcorde ahcorde changed the title Added rmw_event_check_compatible Added rmw_event_type_is_supported Mar 6, 2025
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 7, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 7, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
make linters happy
af08759 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 7, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 8, 2025 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Windows CI failures are unrelated and failing aarch64 job is expected

@ahcorde ahcorde merged commit f202dff into rolling Mar 11, 2025
3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/rmw_event_check_compatible branch March 11, 2025 09:20
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 11, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@ahcorde @MiguelCompany @mergify
Added rmw_event_type_is_supported (#809)
31694b5 
* Added rmw_event_check_compatible

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* Fixed build

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* included review feedback

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* review feedback

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* Update rmw_fastrtps_cpp/src/rmw_event.cpp

Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>

* make linters happy

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit f202dff)
@mergify mergify bot mentioned this pull request Mar 11, 2025
Merged
ahcorde added a commit that referenced this pull request Mar 12, 2025
@mergify @ahcorde
Added rmw_event_type_is_supported (#809) (#813)
9ad233e 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Miguel Company <miguelcompany@eprosima.com>
(cherry picked from commit f202dff)

Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MiguelCompany MiguelCompany MiguelCompany requested changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @MiguelCompany @fujitatomoya