Skip to content

Added rmw_event_type_is_supported#395

Merged
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible
Mar 11, 2025
Merged

Added rmw_event_type_is_supported#395
ahcorde merged 2 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 5, 2025

Related with this issue #394. Check if a event is supported by the rmw

@ahcorde
Added rmw_event_check_compatible
3ec0e40 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Mar 5, 2025
@ahcorde ahcorde mentioned this pull request Mar 5, 2025
Closed
Yadunund
Yadunund requested changes Mar 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback to consider.

@ahcorde
review feedback
2f0230a 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 6, 2025

Pulls: #395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, ros2/rmw_fastrtps#809, ros2/rmw_connextdds#173
Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Mar 6, 2025
Merged
Merged
Merged
Merged
@ahcorde ahcorde changed the title Added rmw_event_check_compatible Added rmw_event_type_is_supported Mar 6, 2025
Yadunund
Yadunund approved these changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was referenced Mar 7, 2025
Merged
Merged
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Windows CI failures are unrelated and failing aarch64 job is expected

@ahcorde ahcorde merged commit 5cf8420 into rolling Mar 11, 2025
3 checks passed
@ahcorde ahcorde deleted the ahcorde/rolling/rmw_event_check_compatible branch March 11, 2025 09:20
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 11, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@ahcorde @mergify
Added rmw_event_type_is_supported (#395)
5931711 
* Added rmw_event_check_compatible

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* review feedback

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 5cf8420)
@mergify mergify bot mentioned this pull request Mar 11, 2025
Merged
ahcorde added a commit that referenced this pull request Mar 12, 2025
@mergify @ahcorde
Added rmw_event_type_is_supported (#395) (#396)
f35ec50 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 5cf8420)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@4ntn 4ntn mentioned this pull request Mar 18, 2025
Merged
@christophebedard christophebedard mentioned this pull request Aug 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yadunund Yadunund Yadunund approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @Yadunund @fujitatomoya