Skip to content

Added rmw_event_type_is_supported#173

Merged
ahcorde merged 3 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible
Mar 11, 2025
Merged

Added rmw_event_type_is_supported#173
ahcorde merged 3 commits intorollingfrom
ahcorde/rolling/rmw_event_check_compatible

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 5, 2025

Related with this issue ros2/rmw#394. Check if a event is supported by the rmw

@ahcorde
Added rmw_event_check_compatible
1728ce8 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund March 5, 2025 13:49
@ahcorde ahcorde mentioned this pull request Mar 5, 2025
Closed
@fgallegosalido fgallegosalido self-requested a review March 5, 2025 17:55
@ahcorde
review feedback
c1a4b47 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
This was referenced Mar 6, 2025
Merged
Merged
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 6, 2025

Pulls: ros2/rmw#395, ros2/rmw_implementation#250, ros2/rmw_cyclonedds#532, ros2/rmw_fastrtps#809, #173
Gist: https://gist.githubusercontent.com/ahcorde/f7979a231857cd476a5e7f5ecc5e96cc/raw/d7b1d7bff818a741abc52a4b3c4a30522a0d8002/ros2.repos
BUILD args: --packages-above-and-dependencies rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
TEST args: --packages-above rmw rmw_implementation rmw_cyclonedds_cpp rmw_fastrtps_cpp rmw_fastrtps_dynamic_cpp rmw_fastrtps_shared_cpp rmw_connextdds_common
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15294

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

This was referenced Mar 6, 2025
Merged
Merged
fgallegosalido
fgallegosalido reviewed Mar 6, 2025
View reviewed changes
rmw_connextdds_common/src/common/rmw_event.cpp Outdated


bool
rmw_event_type_is_supported(rmw_event_type_t rmw_event_type)
Copy link
Copy Markdown
Collaborator

@fgallegosalido fgallegosalido Mar 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep this consistent with how the code is structured, let's make a couple of changes:

  • Call this function rmw_api_connextdds_event_type_is_supported.
  • Add its declaration in the header rmw_connextdds_common/include/rnw_connextdds/rmw_api_impl.hpp in the "Event API" section.
  • Use the implementation of is_even_supported and delete the function.
  • Add the function rmw_event_type_is_supported in both rmw_api_impl_ndds.cpp and rmw_api_impl_rtime.cpp in the "Event API" section using the common rmw_api_connextdds_event_type_is_supported function.

fgallegosalido
fgallegosalido requested changes Mar 6, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fgallegosalido fgallegosalido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde I've added a couple of comments to keep the code consistent. Take a look at then whenever you can

@ahcorde ahcorde changed the title Added rmw_event_check_compatible Added rmw_event_type_is_supported Mar 6, 2025
@ahcorde
Added review feedback
1c1877b 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

Windows CI failures are unrelated and failing aarch64 job is expected

@ahcorde ahcorde merged commit 2f3dbef into rolling Mar 11, 2025
1 check passed
@ahcorde ahcorde deleted the ahcorde/rolling/rmw_event_check_compatible branch March 11, 2025 09:20
@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 11, 2025

https://github.com/Mergifyio backport jazzy

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 11, 2025 •
edited
Loading

backport jazzy

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request Mar 11, 2025
@ahcorde @mergify
Added rmw_event_type_is_supported (#173)
91aeaf2 
* Added rmw_event_check_compatible

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* review feedback

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

* Added review feedback

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>

---------

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 2f3dbef)
@mergify mergify bot mentioned this pull request Mar 11, 2025
Merged
ahcorde added a commit that referenced this pull request Mar 12, 2025
@mergify @ahcorde
Added rmw_event_type_is_supported (#173) (#175)
9207d19 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
(cherry picked from commit 2f3dbef)

Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgallegosalido fgallegosalido fgallegosalido approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @fgallegosalido @fujitatomoya