Skip to content

Remove absolute path from installed CMake code#948

Merged
jacobperron merged 1 commit intomasterfrom
jacob/rclcpp_components_relocatable
Dec 17, 2019
Merged

Remove absolute path from installed CMake code#948
jacobperron merged 1 commit intomasterfrom
jacob/rclcpp_components_relocatable

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

This fix is similar to that done in ros2/test_interface_files#9.

Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron
Copy link
Copy Markdown
Member Author

jacobperron commented Dec 17, 2019

Packages up to demo_nodes_cpp:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status (Edit: Failure also occurred on latest nightly)

@jacobperron jacobperron added the bug Something isn't working label Dec 17, 2019
@jacobperron jacobperron merged commit 0c66d0c into master Dec 17, 2019
@delete-merged-branch delete-merged-branch bot deleted the jacob/rclcpp_components_relocatable branch December 17, 2019 23:23
jacobperron added a commit that referenced this pull request Dec 18, 2019
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Dec 18, 2019
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Jan 8, 2020
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron added a commit that referenced this pull request Jan 17, 2020
Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
nnmm pushed a commit to ApexAI/rclcpp that referenced this pull request Jul 9, 2022
…os2#948)

* Test forward/backward jump callbacks disabled

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>

* Fix 0 thresholds not disabling jump callbacks

Signed-off-by: Shane Loretz <sloretz@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants