Skip to content

remove absolute paths from installed CMake code#9

Merged
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/remove-absolute-path-from-installed-cmake
Aug 15, 2019
Merged

remove absolute paths from installed CMake code#9
dirk-thomas merged 1 commit intomasterfrom
dirk-thomas/remove-absolute-path-from-installed-cmake

Conversation

@dirk-thomas
Copy link
Copy Markdown
Member

Follow up of ros2/ros2#606 (comment)

Ensure that the installed CMake code is relocatable.

  • Linux Build Status

Signed-off-by: Dirk Thomas <dirk-thomas@users.noreply.github.com>
@dirk-thomas dirk-thomas added bug Something isn't working in review labels Aug 15, 2019
@dirk-thomas dirk-thomas requested a review from cottsay August 15, 2019 01:05
@dirk-thomas dirk-thomas self-assigned this Aug 15, 2019
@dirk-thomas dirk-thomas merged commit eaf9e35 into master Aug 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the dirk-thomas/remove-absolute-path-from-installed-cmake branch August 15, 2019 18:08
Copy link
Copy Markdown

@amber6623 amber6623 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dirk-thomas/remove-absolute-path-from-installed-cmake

@dirk-thomas
Copy link
Copy Markdown
Member Author

dirk-thomas/remove-absolute-path-from-installed-cmake

@amber6623 please update your comment to contain full sentences. Atm it is unclear what the purpose of it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working in review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants