Skip to content

[eloquent backport] Remove absolute path from installed CMake code (#948)#950

Merged
jacobperron merged 1 commit intoeloquentfrom
jacob/eloquent_backport_948
Jan 17, 2020
Merged

[eloquent backport] Remove absolute path from installed CMake code (#948)#950
jacobperron merged 1 commit intoeloquentfrom
jacob/eloquent_backport_948

Conversation

@jacobperron
Copy link
Copy Markdown
Member

Backport #948 to Eloquent


Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Otherwise, rclcpp_components_register_node() fails if used from a fat archive.

Related to ros2/ros2#606.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron changed the base branch from master to eloquent December 18, 2019 00:27
@jacobperron jacobperron self-assigned this Dec 18, 2019
Copy link
Copy Markdown
Member

@ivanpauno ivanpauno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@jacobperron
Copy link
Copy Markdown
Member Author

@ros-pull-request-builder retest this please

@jacobperron
Copy link
Copy Markdown
Member Author

Test failures appear unrelated. Merging.

@jacobperron jacobperron merged commit c0ad535 into eloquent Jan 17, 2020
@delete-merged-branch delete-merged-branch bot deleted the jacob/eloquent_backport_948 branch January 17, 2020 21:38
DensoADAS pushed a commit to DensoADAS/rclcpp that referenced this pull request Aug 5, 2022
The PLUGINLIB_DISABLE_BOOST define hasn't been honored (or
even available) in close to 2 years now, so just remove it
from the build.

Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants