Fix: improve exception context for parameter_value_from (backport #2917)#2920
Merged
Fix: improve exception context for parameter_value_from (backport #2917)#2920
Conversation
Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 1f2adc9)
Contributor
|
Pulls: #2920
|
Contributor
|
@ahcorde Oops. Various Windows builds (for multiple PRs) are already running for one day or more... Do we expect these builds to complete? |
Contributor
Contributor
|
@ahcorde @fujitatomoya Some of the end to end tests have failed for Windows. Could these tests be flaky or depend on Windows services temporarily unavailable? Is a retry worth considering? |
ahcorde
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds c_param_name to error messages without changing API interface of parameter_value_from.
Fixes #2916
Is this user-facing behavior change?
Did you use Generative AI?
ChatGPT 4o
Additional Information
I was missing instructions for testing/building. I'm used to having Github automatically building my repos. But it has been a long while since my last bit of CPP. So please edit/improve before merging if that is required.
This is an automatic backport of pull request #2917 done by Mergify.