Skip to content

Fix: improve exception context for parameter_value_from (backport #2917)#2919

Merged
ahcorde merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2917
Aug 18, 2025
Merged

Fix: improve exception context for parameter_value_from (backport #2917)#2919
ahcorde merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-2917

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 30, 2025

Description

Adds c_param_name to error messages without changing API interface of parameter_value_from.

Fixes #2916

Is this user-facing behavior change?

Did you use Generative AI?

ChatGPT 4o

Additional Information

I was missing instructions for testing/building. I'm used to having Github automatically building my repos. But it has been a long while since my last bit of CPP. So please edit/improve before merging if that is required.

This is an automatic backport of pull request #2917 done by Mergify.

@mleegwt @fujitatomoya
@ahcorde @mergify
Fix: improve exception context for parameter_value_from (#2917)
6ba088e 
Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 1f2adc9)
@mergify mergify bot mentioned this pull request Jul 30, 2025
Merged
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jul 30, 2025 •
edited
Loading

Pulls: #2919
Gist: https://gist.githubusercontent.com/ahcorde/d0848353c7d1347e3ab269ff7c7eac55/raw/2d52c61f67b67af031c3f3056906527dd4e5eeb0/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16650

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@mleegwt mleegwt mentioned this pull request Aug 2, 2025
Merged
@mleegwt
Copy link
Copy Markdown
Contributor

mleegwt commented Aug 6, 2025

Three tests have failed for Windows, snippet from log:

7: [  FAILED  ] TestInfoGetServiceInfo/Rosbag2CPPGetServiceInfoTest.get_service_info_for_bag_with_services_only/1, where GetParam() = "mcap"
7: [  FAILED  ] TestInfoGetServiceInfo/Rosbag2CPPGetServiceInfoTest.get_service_info_for_bag_with_topics_and_services/0, where GetParam() = "sqlite3"
7: [  FAILED  ] TestInfoGetServiceInfo/Rosbag2CPPGetServiceInfoTest.get_service_info_for_bag_with_topics_and_services/1, where GetParam() = "mcap"

Could these tests be flaky? Is a retry worth considering?

@ahcorde ahcorde merged commit 14ecbc3 into kilted Aug 18, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/kilted/pr-2917 branch August 18, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ahcorde @mleegwt