Fix: improve exception context for parameter_value_from#2917
Merged
ahcorde merged 5 commits intoros2:rollingfrom Jul 29, 2025
Merged
Fix: improve exception context for parameter_value_from#2917ahcorde merged 5 commits intoros2:rollingfrom
ahcorde merged 5 commits intoros2:rollingfrom
Conversation
Adds c_param_name to error messages without changing API interface of parameter_value_from. Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
I think this is reasonable, lgtm with a few comments.
…eclaration Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Contributor
Author
Thanks! Suggested changes are committed! |
ahcorde
requested changes
Jul 28, 2025
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
approved these changes
Jul 28, 2025
Contributor
|
Pulls: #2917
|
Contributor
Author
|
@ahcorde What happened to the Windows build? |
Contributor
|
Contributor
Author
|
@ahcorde Thanks! I saw there also is a release that includes this fix already. I love it! |
Contributor
|
https://github.com/Mergifyio backport kilted jazzy humble |
Contributor
✅ Backports have been createdDetails
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 1f2adc9)
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 1f2adc9)
This was referenced Jul 30, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 30, 2025
Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> (cherry picked from commit 1f2adc9)
ahcorde
added a commit
that referenced
this pull request
Aug 18, 2025
(cherry picked from commit 1f2adc9) Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Aug 18, 2025
(cherry picked from commit 1f2adc9) Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
ahcorde
added a commit
that referenced
this pull request
Aug 18, 2025
…) (#2921) Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com> Co-authored-by: Michiel Leegwater <mleegwt@users.noreply.github.com> Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds c_param_name to error messages without changing API interface of parameter_value_from.
Fixes #2916
Is this user-facing behavior change?
Did you use Generative AI?
ChatGPT 4o
Additional Information
I was missing instructions for testing/building. I'm used to having Github automatically building my repos. But it has been a long while since my last bit of CPP. So please edit/improve before merging if that is required.