Skip to content

Fix: improve exception context for parameter_value_from (backport #2917)#2921

Merged
ahcorde merged 3 commits intohumblefrom
mergify/bp/humble/pr-2917
Aug 18, 2025
Merged

Fix: improve exception context for parameter_value_from (backport #2917)#2921
ahcorde merged 3 commits intohumblefrom
mergify/bp/humble/pr-2917

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jul 30, 2025

Description

Adds c_param_name to error messages without changing API interface of parameter_value_from.

Fixes #2916

Is this user-facing behavior change?

Did you use Generative AI?

ChatGPT 4o

Additional Information

I was missing instructions for testing/building. I'm used to having Github automatically building my repos. But it has been a long while since my last bit of CPP. So please edit/improve before merging if that is required.


This is an automatic backport of pull request #2917 done by Mergify.

Signed-off-by: Michiel Leegwater <mleegwt@users.noreply.github.com>
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
Co-authored-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
(cherry picked from commit 1f2adc9)
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Jul 30, 2025

Pulls: #2921
Gist: https://gist.githubusercontent.com/ahcorde/a649e7152cd5154b1ff482f9d9937856/raw/01cc904654a13c6c2c3b12410b1fe36fde0e5686/ros2.repos
BUILD args: --packages-above-and-dependencies rclcpp
TEST args: --packages-above rclcpp
ROS Distro: humble
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/16652

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
Copy link
Copy Markdown
Contributor

ahcorde commented Aug 18, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 0036533 into humble Aug 18, 2025
3 checks passed
@ahcorde ahcorde deleted the mergify/bp/humble/pr-2917 branch August 18, 2025 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants