Skip to content

Use EnableRmwIsolation in launch tests#724

Merged
Yadunund merged 2 commits intorollingfrom
cottsay/rmw_test_fixture
May 29, 2025
Merged

Use EnableRmwIsolation in launch tests#724
Yadunund merged 2 commits intorollingfrom
cottsay/rmw_test_fixture

Conversation

@cottsay
Copy link
Copy Markdown
Member

@cottsay cottsay commented May 28, 2025 •
edited
Loading

This reverts (most of) #711 in favor of using the recently introduced rmw_test_fixture.

This should be backported to kilted, but no further.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

cottsay added 2 commits May 28, 2025 14:27
@cottsay
Revert "Set envars to run tests with rmw_zenoh_cpp with multicast dis…
a03a280 
…covery"

This reverts commit 88828e9.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay
Use EnableRmwIsolation in launch tests
3739451 
Signed-off-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay requested review from Yadunund and ahcorde May 28, 2025 19:31
@cottsay cottsay self-assigned this May 28, 2025
Yadunund
Yadunund approved these changes May 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great reference for updating the other repos! Thanks!

@Yadunund Yadunund merged commit 2d283be into rolling May 29, 2025
3 checks passed
@Yadunund
Copy link
Copy Markdown
Member

Yadunund commented May 29, 2025

@Mergifyio backport kilted

@Yadunund Yadunund deleted the cottsay/rmw_test_fixture branch May 29, 2025 01:21
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented May 29, 2025 •
edited
Loading

backport kilted

✅ Backports have been created

Details

mergify bot pushed a commit that referenced this pull request May 29, 2025
@cottsay @mergify
Use EnableRmwIsolation in launch tests (#724)
416a830 
* Revert "Set envars to run tests with rmw_zenoh_cpp with multicast discovery"

This reverts commit 88828e9.

Signed-off-by: Scott K Logan <logans@cottsay.net>

* Use EnableRmwIsolation in launch tests

Signed-off-by: Scott K Logan <logans@cottsay.net>

---------

Signed-off-by: Scott K Logan <logans@cottsay.net>
(cherry picked from commit 2d283be)
@mergify mergify bot mentioned this pull request May 29, 2025
Merged
@fujitatomoya
Copy link
Copy Markdown
Collaborator

fujitatomoya commented May 29, 2025 •
edited
Loading

@Yadunund @cottsay so we should apply the same changes else where like this? if that is the plan, i can help that.

just a question, i see rmw_zenoh_cpp is unstable sometimes especially tests for ros2cli things, this could mitigate that situation? e.g https://ci.ros2.org/job/ci_linux-aarch64/17866/testReport/ros2param.ros2param.test/test_verb_load/test_verb_load/

@Yadunund Yadunund mentioned this pull request May 29, 2025
Open
15 tasks
@Yadunund
Copy link
Copy Markdown
Member

Yadunund commented May 29, 2025

@fujitatomoya that is indeed the plan! We would want to make similar changes for repos listed here ros2/ros2#1664

just a question, i see rmw_zenoh_cpp is unstable sometimes especially tests for ros2cli things, this could mitigate that situation? e.g https://ci.ros2.org/job/ci_linux-aarch64/17866/testReport/ros2param.ros2param.test/test_verb_load/test_verb_load/

We did see some issues with ros2cli tests on multicast that go away when switching to isolated testing. But I'm unclear if the error you linked is a new regression or something we've seen before. Let's apply similar changes and see how it goes!

@cottsay
Copy link
Copy Markdown
Member Author

cottsay commented May 29, 2025

Another good reference PR is ros2/system_tests#571.

I've been plugging away at the ros2cli conversion. It's going to look a little different because the test themselves perform some communication - not just the launch side. So the isolation has to happen "sooner" in the process.

ahcorde pushed a commit that referenced this pull request May 30, 2025
@mergify @cottsay
Use EnableRmwIsolation in launch tests (#724) (#725)
95d6d3c 
(cherry picked from commit 2d283be)

Signed-off-by: Scott K Logan <logans@cottsay.net>
Co-authored-by: Scott K Logan <logans@cottsay.net>
@cottsay cottsay mentioned this pull request Jul 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yadunund Yadunund Yadunund approved these changes

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@cottsay cottsay

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cottsay @Yadunund @fujitatomoya