Enable rmw_test_fixture to run Zenoh router in cross-RMW tests#571
Merged
Enable rmw_test_fixture to run Zenoh router in cross-RMW tests#571
Conversation
Member
Author
|
Member
|
Do we want to revert #567 in this PR? |
Member
|
Looks like Windows is having a bad time here. |
Member
Author
Yeah, fix is here: ros2/ament_cmake_ros#32 |
Member
Author
|
Windows rerun with ros2/ci#813 workaround: |
These macros are provided by the ament_cmake_ros package and use test fixtures to isolate ROS communication. Signed-off-by: Scott K Logan <logans@cottsay.net>
This change enables ROS communication isolation based on one of the two RMWs in the cross-RMW launch tests. At this time, there is no combination of RMWs which are expected to work together which use different isolation fixtures. Signed-off-by: Scott K Logan <logans@cottsay.net>
abd4bd9 to
6c54760
Compare
6c54760 to
2e8fc65
Compare
Member
Author
|
I updated the two commits to include a reference to this PR, and also pushed a commit to revert #567. Fresh CI with the revert as well:
When we're ready, this change should be rebase-merged to preserve the curated commits. |
cottsay
added a commit
that referenced
this pull request
Apr 15, 2025
These macros are provided by the ament_cmake_ros package and use test fixtures to isolate ROS communication. Signed-off-by: Scott K Logan <logans@cottsay.net>
cottsay
added a commit
that referenced
this pull request
Apr 15, 2025
This change enables ROS communication isolation based on one of the two RMWs in the cross-RMW launch tests. At this time, there is no combination of RMWs which are expected to work together which use different isolation fixtures. Signed-off-by: Scott K Logan <logans@cottsay.net>
This was referenced May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.