Skip to content

Set envars to run tests with rmw_zenoh_cpp with multicast discovery#567

Merged
ahcorde merged 8 commits intorollingfrom
ahcorde/rolling/test_zenoh_multicast
Mar 26, 2025
Merged

Set envars to run tests with rmw_zenoh_cpp with multicast discovery#567
ahcorde merged 8 commits intorollingfrom
ahcorde/rolling/test_zenoh_multicast

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 21, 2025

See ros2/rmw_zenoh#567

To test this PR, we can run the usual CI jobs to show there are no regressions and additionally run a CI job with a copy of the ros2.repos file from ros2/ros2#1649 with CI Scripts branch set to yadu/cargo

@ahcorde
Set envars to run tests with rmw_zenoh_cpp with multicast discovery
46de4a2 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund March 21, 2025 18:45
@ahcorde ahcorde changed the title Set envars to run tests with rmw_zenoh_cpp with multicast discovery test_rclcpp: Set envars to run tests with rmw_zenoh_cpp with multicast discovery Mar 21, 2025
@ahcorde ahcorde changed the title test_rclcpp: Set envars to run tests with rmw_zenoh_cpp with multicast discovery Set envars to run tests with rmw_zenoh_cpp with multicast discovery Mar 21, 2025
ahcorde added 2 commits March 21, 2025 19:50
@ahcorde
test_quality_of_service
35066c0 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
add test communication
fc5d13d 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@Yadunund Yadunund mentioned this pull request Mar 21, 2025
Closed
7 tasks
@Yadunund
Fix build for test_communication and cleanup
610382e 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund force-pushed the ahcorde/rolling/test_zenoh_multicast branch from a506aab to 610382e Compare March 21, 2025 20:49
Yadunund added 2 commits March 22, 2025 02:14
@Yadunund
Actually pass RMW args to custom_launch_test_two_executables
53d7d3b 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund
Set envars in more tests in test_communication
1a10d62 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund force-pushed the ahcorde/rolling/test_zenoh_multicast branch from 31af1c7 to 1a10d62 Compare March 22, 2025 03:24
@Yadunund
lint
5cc51f3 
Signed-off-by: Yadunund <yadunund@gmail.com>
@ros-discourse
Copy link
Copy Markdown

ros-discourse commented Mar 25, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-minutes-for-march-25-2025/42807/1

@Yadunund
Cleanup
36b76fe 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund force-pushed the ahcorde/rolling/test_zenoh_multicast branch from 2c917bb to 36b76fe Compare March 25, 2025 23:22
@Yadunund Yadunund marked this pull request as ready for review March 25, 2025 23:53
@Yadunund
Copy link
Copy Markdown
Member

Yadunund commented Mar 26, 2025

Gist (default ros2.repos with changes from this branch): https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/a9d2a2fcb87a7f34426aacfd4836a0ee9c6ad6b5/ros2_ci.repos
BUILD_ARGS: --packages-up-to test_communication test_quality_of_service test_rclcpp
TEST_ARGS: --packages-select test_communication test_quality_of_service test_rclcpp

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit e797b66 into rolling Mar 26, 2025
2 checks passed
@Yadunund Yadunund mentioned this pull request Mar 26, 2025
Open
15 tasks
cottsay added a commit that referenced this pull request Apr 12, 2025
@cottsay
Revert "Set envars to run tests with rmw_zenoh_cpp with multicast dis…
abcbd96 
…covery (#567)"

This reverts commit e797b66.
cottsay added a commit that referenced this pull request Apr 12, 2025
@cottsay
Revert "Set envars to run tests with rmw_zenoh_cpp with multicast dis…
ea41831 
…covery (#567)"

This reverts commit e797b66.

Signed-off-by: Scott K Logan <logans@cottsay.net>
@Yadunund Yadunund mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @ros-discourse @Yadunund @fujitatomoya