Skip to content

Set envars to run tests with rmw_zenoh_cpp with multicast discovery#711

Merged
ahcorde merged 4 commits intorollingfrom
ahcorde/rolling/test_zenoh_multicast
Mar 26, 2025
Merged

Set envars to run tests with rmw_zenoh_cpp with multicast discovery#711
ahcorde merged 4 commits intorollingfrom
ahcorde/rolling/test_zenoh_multicast

Conversation

@ahcorde
Copy link
Copy Markdown
Contributor

@ahcorde ahcorde commented Mar 21, 2025

See ros2/rmw_zenoh#567

To test this PR, we can run the usual CI jobs to show there are no regressions and additionally run a CI job with a copy of the ros2.repos file from ros2/ros2#1649 with CI Scripts branch set to yadu/cargo

@ahcorde
Set envars to run tests with rmw_zenoh_cpp with multicast discovery
437cba8 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from Yadunund March 21, 2025 18:54
@ahcorde ahcorde self-assigned this Mar 21, 2025
@ahcorde
add demo nodes cpp, image_tools, intra process and logging
a671972 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@Yadunund Yadunund mentioned this pull request Mar 21, 2025
Closed
7 tasks
@Yadunund
Fix pendulum_control and cleanup
9740a08 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund
Copy link
Copy Markdown
Member

Yadunund commented Mar 25, 2025 •
edited
Loading

Gist (default ros2.repos with changes from this branch): https://gist.githubusercontent.com/Yadunund/c4074b12ea5bdedcddae7b60f60c34bc/raw/a9d2a2fcb87a7f34426aacfd4836a0ee9c6ad6b5/ros2_ci.repos
BUILD_ARGS: --packages-up-to composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control
TEST_ARGS: --packages-select composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Gist (rmw_zenoh with changes from this branch): https://raw.githubusercontent.com/ros2/ros2/3f873e9c5a79ce3b47f70199708b21c07007cd7d/ros2.repos
BUILD_ARGS: --packages-up-to rmw_zenoh_cpp composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control
TEST_ARGS: --packages-select composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ros-discourse
Copy link
Copy Markdown

ros-discourse commented Mar 25, 2025

This pull request has been mentioned on ROS Discourse. There might be relevant details there:

https://discourse.ros.org/t/ros-pmc-minutes-for-march-25-2025/42807/1

@Yadunund
Cleanup
569a826 
Signed-off-by: Yadunund <yadunund@gmail.com>
@Yadunund Yadunund force-pushed the ahcorde/rolling/test_zenoh_multicast branch from 24a2c7f to 569a826 Compare March 25, 2025 22:47
fujitatomoya
fujitatomoya approved these changes Mar 26, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 26, 2025

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Copy Markdown
Contributor Author

ahcorde commented Mar 26, 2025 •
edited
Loading

Pulls: #711
Gist: https://gist.githubusercontent.com/ahcorde/915caf40627b7c7b56477e9dfe44a909/raw/c8248f2f6d784838a029e92320c5586153f55952/ros2.repos
BUILD args: --packages-up-to composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control --packages-above-and-dependencies composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control
TEST args: --packages-select composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control --packages-above composition demo_nodes_cpp image_tools intra_process_demo logging_demo pendulum_control
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/15481

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde ahcorde merged commit 88828e9 into rolling Mar 26, 2025
2 checks passed
This was referenced Mar 26, 2025
Open
Merged
@fujitatomoya fujitatomoya mentioned this pull request Mar 28, 2025
Merged
@cottsay cottsay mentioned this pull request May 28, 2025
Merged
@mergify mergify bot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@Yadunund Yadunund Awaiting requested review from Yadunund

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ahcorde @Yadunund @ros-discourse @fujitatomoya