Use urdf::*ShredPtr instead of boost::shared_ptr#1044
Merged
wjwwood merged 1 commit intoros-visualization:kinetic-develfrom Sep 6, 2016
Merged
Use urdf::*ShredPtr instead of boost::shared_ptr#1044wjwwood merged 1 commit intoros-visualization:kinetic-develfrom
wjwwood merged 1 commit intoros-visualization:kinetic-develfrom
Conversation
Member
|
It doesn't look like I wonder why the urdf types were forward declared and if that was necessary. Other than that lingering curiosity, the changes look reasonable to me. Thanks! |
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers
c1578fb to
c2cb77a
Compare
Contributor
Author
|
Fixed the name, thanks for spotting. I was wondering about the forward declarations as well, but they are older then the git, guess it's not needed anymore.
|
Contributor
|
@jspricke You should explicitly require urdfdom_headers >= 0.4. Before, the typedefs are not available. |
Contributor
Author
|
Hi Robert, this one is merged already, so feel free to open a new pull
request if needed ;).
|
Member
|
Sorry, I didn't follow up on @rhaschke's comment. Indeed this breaks the build on Wily and Debian Jessie. I guess I need to revert this change or apply a fix like @rhaschke did for |
Member
|
I think I'm going to revert this and open an issue to resolve it in the future. I'm not sure it makes sense to replicate the work in moveit/srdfdom#25 in rviz and every other ROS package that uses urdf. Perhaps this compatibility shim should be put in into |
This was referenced Oct 19, 2016
Member
Merged
wjwwood
pushed a commit
that referenced
this pull request
Oct 27, 2016
* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package
wjwwood
pushed a commit
that referenced
this pull request
Jun 5, 2017
* Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package
wjwwood
added a commit
that referenced
this pull request
Jun 5, 2017
* Add fullscreen option. (#1017) * urdfdom compatibility (#1064) * Use urdf::*ShredPtr instead of boost::shared_ptr (#1044) urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom *SharedPtr type, we can use the to sty compatible. This also adds a proper dependency for urdfdom-headers * adaptions to build against both urdfdom 0.3 and 0.4 ... relying on the compatibility layer of urdf package * Update display if empty pointcloud2 is published (#1073) Do not show last point cloud any more, if published point cloud message does not contain any points * Correctly scale the render panel on high resolution displays (#1078) * support multiple material for one link (#1079) * Fixed duplicate property name for Path colors (#1089) See issue #1087. * fix type error in newer versions of urdf (#1098) * Use unique material names for robot links. (#1102) * avoid C++11 feature for back port to indigo
DLu
pushed a commit
to DLu/rviz
that referenced
this pull request
Dec 11, 2025
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
urdfdom_headers uses C++ std::shared_ptr. As it exports it as custom
*SharedPtr type, we can use the to sty compatible.
This also adds a proper dependency for urdfdom-headers